Matt Zimmerman
2005-Nov-17 23:18 UTC
Bug#339686: Fails where shadow passwords are disabled
Package: adduser Version: 3.78ubuntu1 Severity: important Tags: patch Many chroot environments don''t use shadow passwords, and adduser seems to fail in those enviroments now. The code in adduser attempts to cope with this, but it''s defeated by the check within the systemcall function. Patch attached. -- System Information: Debian Release: testing/unstable APT prefers dapper APT policy: (500, ''dapper'') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.12-9-k7 Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Versions of packages adduser depends on: ii debconf [debconf-2.0] 1.4.59ubuntu1 Debian configuration management sy ii passwd 1:4.0.13-6ubuntu1 change and administer password and ii perl-base 5.8.7-8 The Pathologically Eclectic Rubbis adduser recommends no packages. -- debconf information excluded -- - mdz _______________________________________________ Adduser-devel mailing list Adduser-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/adduser-devel
Marc Haber
2005-Nov-18 17:33 UTC
[Adduser-devel] Bug#339686: Fails where shadow passwords are disabled
tags #339686 patch confirmed pending severity #339686 serious # this is an rc bug in the maintainer''s opinion. thanks On Thu, Nov 17, 2005 at 03:10:08PM -0800, Matt Zimmerman wrote:> Many chroot environments don''t use shadow passwords, and adduser seems to > fail in those enviroments now.It fails, _again_. duh. How many more times will these few lines of code break? Fixed in svn. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don''t trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835
Debian Bug Tracking System
2005-Nov-18 17:33 UTC
[Adduser-devel] Processed: Re: Fails where shadow passwords are disabled
Processing commands for control@bugs.debian.org:> tags #339686 patch confirmed pendingBug#339686: Fails where shadow passwords are disabled Tags were: patch Tags added: patch, confirmed, pending> severity #339686 seriousBug#339686: Fails where shadow passwords are disabled Severity set to `serious''.> # this is an rc bug in the maintainer''s opinion. > thanksStopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Debian Bug Tracking System
2005-Nov-18 18:03 UTC
[Adduser-devel] Bug#339686: marked as done (Fails where shadow passwords are disabled)
Your message dated Fri, 18 Nov 2005 09:47:04 -0800 with message-id <E1EdAKG-0004y3-52@spohr.debian.org> and subject line Bug#339686: fixed in adduser 3.79 has caused the attached Bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -------------------------------------- Received: (at submit) by bugs.debian.org; 17 Nov 2005 23:10:47 +0000>From mdz@ubuntu.com Thu Nov 17 15:10:47 2005Return-path: <mdz@ubuntu.com> Received: from mta9.adelphia.net ([68.168.78.199]) by spohr.debian.org with esmtp (Exim 4.50) id 1Ecstz-000436-44 for submit@bugs.debian.org; Thu, 17 Nov 2005 15:10:47 -0800 Received: from mizar.alcor.net ([68.66.78.251]) by mta9.adelphia.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20051117231013.BOKD17844.mta9.adelphia.net@mizar.alcor.net> for <submit@bugs.debian.org>; Thu, 17 Nov 2005 18:10:13 -0500 Received: by mizar.alcor.net (Postfix, from userid 1000) id 9185E3CA0B; Thu, 17 Nov 2005 15:10:08 -0800 (PST) Date: Thu, 17 Nov 2005 15:10:08 -0800 From: Matt Zimmerman <mdz@ubuntu.com> To: Debian Bug Tracking System <submit@bugs.debian.org> Subject: Fails where shadow passwords are disabled Message-ID: <20051117231008.GA24815@alcor.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline X-Reportbug-Version: 3.17ubuntu1 User-Agent: Mutt/1.5.11 Delivered-To: submit@bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-7.5 required=4.0 tests=BAYES_00,HAS_PACKAGE, RCVD_IN_SORBS autolearn=no version=2.60-bugs.debian.org_2005_01_02 --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Package: adduser Version: 3.78ubuntu1 Severity: important Tags: patch Many chroot environments don''t use shadow passwords, and adduser seems to fail in those enviroments now. The code in adduser attempts to cope with this, but it''s defeated by the check within the systemcall function. Patch attached. -- System Information: Debian Release: testing/unstable APT prefers dapper APT policy: (500, ''dapper'') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.12-9-k7 Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Versions of packages adduser depends on: ii debconf [debconf-2.0] 1.4.59ubuntu1 Debian configuration management sy ii passwd 1:4.0.13-6ubuntu1 change and administer password and ii perl-base 5.8.7-8 The Pathologically Eclectic Rubbis adduser recommends no packages. -- debconf information excluded -- - mdz --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="adduser-chage.diff" diff -Nru /tmp/InEuVwVKcO/adduser-3.78/adduser /tmp/R5W8T7emGw/adduser-3.78ubuntu1/adduser --- /tmp/InEuVwVKcO/adduser-3.78/adduser 2005-11-15 14:44:39.000000000 -0800 +++ /tmp/R5W8T7emGw/adduser-3.78ubuntu1/adduser 2005-11-17 14:45:06.000000000 -0800 @@ -374,8 +374,8 @@ &systemcall(''/usr/sbin/useradd'', ''-d'', $home_dir, ''-g'', $ingroup_name, ''-s'', $shell, ''-u'', $new_uid, $new_name); print "/usr/bin/chage -M 99999 $new_name\n" if ($verbose > 1); - if (&systemcall(''/usr/bin/chage'', ''-M'', ''99999'', $new_name)) { - if( ($?>>8) ne 15 ) { + if (system("/usr/bin/chage -M 99999 $new_name")) { + if( ($?>>8) != 15 ) { &cleanup("$0: `/usr/bin/chage -M 99999 $new_name'' returned error code " . ($?>>8) . ". Aborting.\n") if ($?>>8); &cleanup("$0: `/usr/bin/chage -M 99999 $new_name'' exited from signal " . ($?&255) . ". Aborting.\n"); --2oS5YaxWCcQjTEyO-- --------------------------------------- Received: (at 339686-close) by bugs.debian.org; 18 Nov 2005 17:51:20 +0000>From katie@ftp-master.debian.org Fri Nov 18 09:51:20 2005Return-path: <katie@ftp-master.debian.org> Received: from katie by spohr.debian.org with local (Exim 4.50) id 1EdAKG-0004y3-52; Fri, 18 Nov 2005 09:47:04 -0800 From: Marc Haber <mh+debian-packages@zugschlus.de> To: 339686-close@bugs.debian.org X-Katie: $Revision: 1.56 $ Subject: Bug#339686: fixed in adduser 3.79 Message-Id: <E1EdAKG-0004y3-52@spohr.debian.org> Sender: Archive Administrator <katie@ftp-master.debian.org> Date: Fri, 18 Nov 2005 09:47:04 -0800 X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02 Source: adduser Source-Version: 3.79 We believe that the bug you reported is fixed in the latest version of adduser, which is due to be installed in the Debian FTP archive: adduser_3.79.dsc to pool/main/a/adduser/adduser_3.79.dsc adduser_3.79.tar.gz to pool/main/a/adduser/adduser_3.79.tar.gz adduser_3.79_all.deb to pool/main/a/adduser/adduser_3.79_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 339686@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Marc Haber <mh+debian-packages@zugschlus.de> (supplier of updated adduser package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Fri, 18 Nov 2005 17:29:46 +0000 Source: adduser Binary: adduser Architecture: source all Version: 3.79 Distribution: unstable Urgency: low Maintainer: Debian Adduser Developers <adduser-devel@lists.alioth.debian.org> Changed-By: Marc Haber <mh+debian-packages@zugschlus.de> Description: adduser - Add and remove users and groups Closes: 339670 339686 Changes: adduser (3.79) unstable; urgency=low . * Fix shadowless systems _again_. Thanks to Matt Zimmerman. (mh) Closes: #339686 * remove double values from adduser.conf. (mh) * Allow underscores in adduser.conf variable names. Thanks to David Bishop and Edward J. Shornock. (mh) Closes: #339670 Files: b9a400e1f9f0a074a3b77642f7d3f45e 643 admin important adduser_3.79.dsc fa2adfc1e04e34dd375a0569cdd05590 173275 admin important adduser_3.79.tar.gz 7d062ff2c3d40186fdb1ad2c1ecf5479 130316 admin important adduser_3.79_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iEYEARECAAYFAkN+EHgACgkQgZalRGu6PITqQgCdHE94jCgfwPM1VzVZiED4hkSd cmcAnA9id1aykbGPBUShdgMbCCBaGIfo =ntVr -----END PGP SIGNATURE-----