llvm dev - May 2014 - [LLVMdev] What is HexagonTargetMachine::addPassesForOptimizations for?

On 4/30/2014 2:00 PM, Matthew Curtis wrote:
> On 4/30/2014 9:01 AM, Krzysztof Parzyszek wrote:
>> On 4/30/2014 8:45 AM, Rafael Espíndola wrote:
>>> On 30 April 2014 00:52, Craig Topper <craig.topper at
gmail.com> wrote:
>>>> This function is marked virtual but doesn't override
anything,
>>>> doesn't have
>>>> any overrides, and has no in tree callers. Can it be removed?
>>>
>>> Given that it is dead, yes :-)
>>>
>>
>> It used to be called from clang, from lib/CodeGen/BackendUtils.cpp, 
>> function CreatePasses.  It doesn't seem to be the case anymore. 
I'm
>> not familiar with that part of the code.
>> +Matthew
>>
>> -Krzysztof
>>
>
> It is actually part of a patch that we do not intend to upstream. 
> Unfortunately this part of the patch slipped through. IMO it is ok to 
> remove.
> +Pranav who is even more familiar with the code.
>
Yes, we do not need this any more. It is ok to remove.

Pranav

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation

Pranav, can you remove it?


On Wed, Apr 30, 2014 at 3:15 PM, Pranav Bhandarkar
<pranavb at codeaurora.org>wrote:
> On 4/30/2014 2:00 PM, Matthew Curtis wrote:
>
>> On 4/30/2014 9:01 AM, Krzysztof Parzyszek wrote:
>>
>>> On 4/30/2014 8:45 AM, Rafael Espíndola wrote:
>>>
>>>> On 30 April 2014 00:52, Craig Topper <craig.topper at
gmail.com> wrote:
>>>>
>>>>> This function is marked virtual but doesn't override
anything, doesn't
>>>>> have
>>>>> any overrides, and has no in tree callers. Can it be
removed?
>>>>>
>>>>
>>>> Given that it is dead, yes :-)
>>>>
>>>>
>>> It used to be called from clang, from lib/CodeGen/BackendUtils.cpp,
>>> function CreatePasses.  It doesn't seem to be the case anymore.
I'm not
>>> familiar with that part of the code.
>>> +Matthew
>>>
>>> -Krzysztof
>>>
>>>
>> It is actually part of a patch that we do not intend to upstream.
>> Unfortunately this part of the patch slipped through. IMO it is ok to
>> remove.
>> +Pranav who is even more familiar with the code.
>>
>>  Yes, we do not need this any more. It is ok to remove.
>
> Pranav
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140430/db436430/attachment.html>

On 4/30/2014 5:24 PM, Craig Topper wrote:
> Pranav, can you remove it?
>
Yes, I'll remove it.

Pranav

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation