Simon Atanasyan
2014-Apr-02 04:51 UTC
[LLVMdev] [lld] Verifying the Architecture of files read
On Wed, Apr 2, 2014 at 7:47 AM, Shankar Easwaran <shankare at codeaurora.org> wrote:> I am not sure if you looked at this thread > (http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-October/066155.html) > > let me know if you still have questions. > > As a short summary, we dont verify the architecture of files that are being > read. We could very well be passed in a hexagon input file while the target > specified was x86_64. we got to reject the input file as the user has chosen > the architecture to be x86_64.Moreover, inside MIPS architecture there are some incompatible "sub-architectures". It would be nice if we can check input files and reject incorrect combinations. -- Simon Atanasyan
Shankar Easwaran
2014-Apr-02 04:59 UTC
[LLVMdev] [lld] Verifying the Architecture of files read
On 4/1/2014 11:51 PM, Simon Atanasyan wrote:> On Wed, Apr 2, 2014 at 7:47 AM, Shankar Easwaran > <shankare at codeaurora.org> wrote: >> I am not sure if you looked at this thread >> (http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-October/066155.html) >> >> let me know if you still have questions. >> >> As a short summary, we dont verify the architecture of files that are being >> read. We could very well be passed in a hexagon input file while the target >> specified was x86_64. we got to reject the input file as the user has chosen >> the architecture to be x86_64. > Moreover, inside MIPS architecture there are some incompatible > "sub-architectures". It would be nice if we can check input files and > reject incorrect combinations.For a simple design, I was thinking that the LinkingContext per flavor could store input file information as its processed by the linker and choose to reject files or accept them. The only problem here is that since the input files are parsed in parallel, how do we want to deal with this scenario ? Thanks Shankar Easwaran -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
So is for PE32 and PE32+. They cannot be mixed because they are for x86 and x86-64, respectively. I'd think we can simply wait for all files to be parsed and pass them to a LinkingContext to ask whether or not the input file set seems OK. On Tue, Apr 1, 2014 at 9:59 PM, Shankar Easwaran <shankare at codeaurora.org>wrote:> On 4/1/2014 11:51 PM, Simon Atanasyan wrote: > >> On Wed, Apr 2, 2014 at 7:47 AM, Shankar Easwaran >> <shankare at codeaurora.org> wrote: >> >>> I am not sure if you looked at this thread >>> (http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-October/066155.html) >>> >>> let me know if you still have questions. >>> >>> As a short summary, we dont verify the architecture of files that are >>> being >>> read. We could very well be passed in a hexagon input file while the >>> target >>> specified was x86_64. we got to reject the input file as the user has >>> chosen >>> the architecture to be x86_64. >>> >> Moreover, inside MIPS architecture there are some incompatible >> "sub-architectures". It would be nice if we can check input files and >> reject incorrect combinations. >> > For a simple design, I was thinking that the LinkingContext per flavor > could store input file information as its processed by the linker and > choose to reject files or accept them. > > The only problem here is that since the input files are parsed in > parallel, how do we want to deal with this scenario ? > > > Thanks > > Shankar Easwaran > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted > by the Linux Foundation > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140401/339e417e/attachment.html>
Possibly Parallel Threads
- [LLVMdev] [lld] Verifying the Architecture of files read
- [LLVMdev] [lld] Verifying the Architecture of files read
- [LLVMdev] [lld] Verifying the Architecture of files read
- [LLVMdev] [lld] Verifying the Architecture of files read
- [LLVMdev] [lld] Verifying the Architecture of files read