llvm dev - Feb 2014 - [LLVMdev] Why doesn't GlobalVariable::copyAttributesFrom copy the thread local mode?

GlobalVariable::copyAttributesFrom sets the target thread local mode to
either general dynamic or not thread local rather than copying the thread
local mode from the source. Is that intentional or an oversight?

Thanks,
Keno
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140208/2686fdfa/attachment.html>

On 8 February 2014 00:40, Keno Fischer <kfischer at college.harvard.edu>
wrote:
> GlobalVariable::copyAttributesFrom sets the target thread local mode to
> either general dynamic or not thread local rather than copying the thread
> local mode from the source. Is that intentional or an oversight?
I think it is just not implemented yet. We added support for having
explicit thread mode in r159077 and I think we just forgot to update
this code.

Do you want to write a patch for it? :-)

Cheers,
Rafael

On Mon, Feb 10, 2014 at 8:17 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 8 February 2014 00:40, Keno Fischer <kfischer at
college.harvard.edu> wrote:
>> GlobalVariable::copyAttributesFrom sets the target thread local mode to
>> either general dynamic or not thread local rather than copying the
thread
>> local mode from the source. Is that intentional or an oversight?
>
> I think it is just not implemented yet. We added support for having
> explicit thread mode in r159077 and I think we just forgot to update
> this code.
Fixed in r201098.

Thanks,
Hans