llvm dev - Oct 2013 - [LLVMdev] [MSVC] Adding LLVM build target support in VS2013 projects

Hi,

I have attached a small patch from r192263 that I am using to add LLVM into the
toolchain for VS2013.
Is someone able to review this and (if all good) submit to the source tree?

Changes are all local to llvm/tools/msbuild/ and account for VS2013 requiring
the files to be named toolset.props / .targets, rather than the longer name in
the previous versions.

Cheers,
Joshua Samuel
**********************************************************************************************
Important Note
This email (including any attachments) contains information which is
confidential and may be subject to legal privilege.  If you are not the intended
recipient you must not use, distribute or copy this email.  If you have received
this email in error please notify the
sender immediately and delete this email. Any views expressed in this email are
not necessarily the views of IRESS Limited.

It is the duty of the recipient to virus scan and otherwise test the information
provided before loading onto any computer system.
IRESS Limited does not warrant that the information is free of a virus or any
other defect or error.
**********************************************************************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131009/842afff3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-vs2012.patch
Type: application/octet-stream
Size: 5808 bytes
Desc: llvm-vs2012.patch
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131009/842afff3/attachment.obj>

On Tue, Oct 8, 2013 at 7:13 PM, Josh Samuel <JSamuel at iress.com.au>
wrote:
> I have attached a small patch from r192263 that I am using to add LLVM into
> the toolchain for VS2013.
>
> Is someone able to review this and (if all good) submit to the source tree?
I don't have VS2013 to verify this with, but the patch looks good and
since it works for you, I've committed it in r192371.

Thanks,
Hans

I tried to test the new Windows build, but unfortunately there is only a 

props file for VS2013. The targets file is missing.

Hi,

It looks like I forgot to "svn add" the 2 targets files, and a typo
appeared in the CMakelists.txt

Fixes attached.    "Works on my machine guarantee" ;-)

Note - to actually compile the MSVC v120 header files will take a fair bit more
work - there are a number of type traits not implemented by clang, that are
breaking my MFC builds at the moment.  (And a few compiler switches, that will
be a separate patch for clang when I'm happier with them)

Cheers,
Josh


-----Original Message-----
From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf Of Hans
Wennborg
Sent: Friday, 11 October 2013 4:38 AM
To: Josh Samuel
Cc: llvmdev at cs.uiuc.edu
Subject: Re: [LLVMdev] [MSVC] Adding LLVM build target support in VS2013
projects

On Tue, Oct 8, 2013 at 7:13 PM, Josh Samuel <JSamuel at iress.com.au>
wrote:
> I have attached a small patch from r192263 that I am using to add LLVM 
> into the toolchain for VS2013.
>
> Is someone able to review this and (if all good) submit to the source tree?
I don't have VS2013 to verify this with, but the patch looks good and since
it works for you, I've committed it in r192371.

Thanks,
Hans
**********************************************************************************************
Important Note
This email (including any attachments) contains information which is
confidential and may be subject to legal privilege.  If you are not the intended
recipient you must not use, distribute or copy this email.  If you have received
this email in error please notify the
sender immediately and delete this email. Any views expressed in this email are
not necessarily the views of IRESS Limited.

It is the duty of the recipient to virus scan and otherwise test the information
provided before loading onto any computer system.
IRESS Limited does not warrant that the information is free of a virus or any
other defect or error.
**********************************************************************************************
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-msvcpatch2.patch
Type: application/octet-stream
Size: 2259 bytes
Desc: llvm-msvcpatch2.patch
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131014/81b27ae5/attachment.obj>