Adduser devel - Jul 2006 - Bug#377387: Improvements for the program output

Package: adduser
Version: 3.92
Severity: normal
Tags: patch

Hi,

I''m currently updating the German translation for your package, and
while
performing the reviewing process on our translation mailing list, we''ve
discovered quite a few inconsistencies with regard to the program''s
output
messages.

The attached patch fixes the following issues:

1. UID/GID are not written in uppercase everywhere (uid/gid appears as well)

2. Likewise, I''ve replaced "user" and "group" with
their uppercase
equivalents in the help text for the program usage.

3. If you use three dots as an ellipsis, you need to insert a space before 
the first dot. Otherwise, it would indicate that a part of the previous 
word is missing. (e.g. "Adding group `%s'' (%d) ..." instead
of "Adding
group `%s'' (%d)...")

4. I''ve replaced %s with %d where applicable, to ease the understanding
for
translators

5. I''ve rephrased the error message "can''t close mount
pipe: %s\n"
with "pipe of command `mount'' could not be closed: %s\n". The
former
version did give us a headache, as we could not understand what the message 
was intended to say

6. There are some other small rewordings as well

7. I''ve replaced "Aborting" with "Exiting", to make
the program''s output
more consistent. As I understand it, the result is in both cases the same, 
namely the termination of the program.

8. The message "Couldn''t parse `%s'':%s.\n" has been
changed to "Couldn''t
parse `%s'', line %d.\n", because we first thought that the second
%s is the
actual error message, and not the line number

9. A few output strings which were not shown with gtx() have been added now

10. I''ve updated your copyright statement with the current address of
the
FSF

11. Last, not least, I''d suggest to add your mailing list as the
contact
address for msgid bugs.


I know that several issues could be reported with a different bug each time, 
but I felt that all suggestions are relatively small, so I generated a 
cumulative patch. If this is not appropriate, let me know, and I''ll
split
the patch up for you.

Regards,
Tobias

-- 
Tobias Toedter   | Time is what keeps things from happening all at once.
Hamburg, Germany |



_______________________________________________
Adduser-devel mailing list
Adduser-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/adduser-devel

On Sat, Jul 08, 2006 at 05:56:05PM +0200, Tobias Toedter
wrote:
> I''m currently updating the German translation for your package,
and while
> performing the reviewing process on our translation mailing list,
we''ve
> discovered quite a few inconsistencies with regard to the
program''s output
> messages.
Thanks for your efforts. I have deleted the issues I agree with.
> 1. UID/GID are not written in uppercase everywhere (uid/gid appears as
well)
I am not sure wheter it would be better to write uid/gid. Is there an
accepted standard for thhis writing?
> 4. I''ve replaced %s with %d where applicable, to ease the
understanding for
> translators
Is that compatible and does not generate decimal numbers with fractions?
> 9. A few output strings which were not shown with gtx() have been added now
Please try the changes, there are a few places where we hat to omit
gtx for obscure reasons.

I''ll need to review the Y/n stuff you changed, there was no time at
the moment.

After the issues mentioned above have been resolved, I''ll apply your
patch in svn. Thanks for helping.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

On Saturday 08 July 2006 18:32, Marc Haber wrote:
> On Sat, Jul 08, 2006 at 05:56:05PM +0200, Tobias Toedter wrote:
> > 1. UID/GID are not written in uppercase everywhere (uid/gid appears as
> > well)
>
> I am not sure wheter it would be better to write uid/gid. Is there an
> accepted standard for thhis writing?
No, none that I''m aware of. If you think that uid/gid would be better,
feel
free to change the uppercase UID/GID to lowercase. The main point here was 
to keep the messages consistent.

However, I think that UID/GID makes it clearer to the user that we''re 
talking about a variable. The uppercase version has been used in the 
program''s usage output as well. As an alternative, you could write
"user
id" and "group id".
> > 4. I''ve replaced %s with %d where applicable, to ease the
understanding
> > for translators
>
> Is that compatible and does not generate decimal numbers with fractions?
Yes, %d will display an integer value, even if you supply a fractional 
number. In that case, the number will be converted to integer 
automatically. If you want to display fractions, you would need to use %f 
instead.
> > 9. A few output strings which were not shown with gtx() have been
added
> > now
>
> Please try the changes, there are a few places where we hat to omit
> gtx for obscure reasons.
I guess these places are where you use Perl variables in the output, 
e.g. "Could not create user $new_user: $!\n". You cannot use gtx then,
because it will irritate xgettext. That''s why I enclosed the calls to
gtx()
with calls to sprintf().

I have checked all newly introduced gtx() calls, they work fine. Expect one 
small mistake: in AdduserCommon.pm, the call to die() has been replaced 
with dief(), which prepends the output with "$0:" itself. Therefore
the
following patch fragment needs to be replaced:

@@ -155,9 +155,9 @@
     my $c = join('' '', @_);
     print ("$c\n") if $verbose==2;
     if (system(@_)) {
-        die ("$0: `$c'' returned error code " . ($?>>8)
. ".  Aborting.\n")
+        dief (gtx("%s: `%s'' returned error code %d.
Exiting.\n"), $0, $c,
$?>>8)
           if ($?>>8);
-        die ("$0: `$c'' exited from signal " . ($?&255) .
".  Aborting.\n");
+        dief (gtx("%s: `%s'' exited from signal %d.
Exiting.\n"), $0, $c,
$?&255);
     }
 }
 

Change the calls to dief() to read as follows:

dief (gtx("`%s'' returned error code %d. Exiting.\n"), $c,
$?>>8)
and
dief (gtx("`%s'' exited from signal %d. Exiting.\n"), $c,
$?&255);
> I''ll need to review the Y/n stuff you changed, there was no time
at
> the moment.
OK.
> After the issues mentioned above have been resolved, I''ll apply
your
> patch in svn. Thanks for helping.
Thanks for your quick feedback.

Regards,
Tobias

-- 
Tobias Toedter   | "To be is to do"  -- Plato
Hamburg, Germany | "To do is to be"  -- Aristotle
                 | "Do be do be do"  -- Sinatra
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060708/ca0a5696/attachment.pgp

On Sat, Jul 08, 2006 at 07:27:12PM +0200, Tobias Toedter
wrote:
> On Saturday 08 July 2006 18:32, Marc Haber wrote:
> > On Sat, Jul 08, 2006 at 05:56:05PM +0200, Tobias Toedter wrote:
> > > 1. UID/GID are not written in uppercase everywhere (uid/gid
appears as
> > > well)
> >
> > I am not sure wheter it would be better to write uid/gid. Is there an
> > accepted standard for thhis writing?
> 
> No, none that I''m aware of. If you think that uid/gid would be
better, feel
> free to change the uppercase UID/GID to lowercase. The main point here was 
> to keep the messages consistent.
the man page for setuid uses the capitalized form as well. So you''re
right.
> > the moment.
> 
> OK.
A real no-brainer, your patch is of course perfectly valid.

I have applied your patch in svn. However, I am still not comfortable
with some of our strings and will thus run the code past
debian-l10n-english before the next upload.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

On Sun, Jul 09, 2006 at 11:46:37PM +0200, Tobias Toedter
wrote:
> By the way, there are some more things that I 
> spotted in the code, should I submit a new bug or can I just send the patch
> directly to you or the mailing list?
I''d prefer a new bug for tracking purposes, thanks ;)

Please create a patch against current svn HEAD, that''s easiest for me
to apply.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

On Sunday 09 July 2006 19:00, Marc Haber wrote:
[UID/GID vs. uid/gid]
> the man page for setuid uses the capitalized form as well. So
you''re
> right.
Alright.

[yes/no patch]
> A real no-brainer, your patch is of course perfectly valid.
>
> I have applied your patch in svn. However, I am still not comfortable
> with some of our strings and will thus run the code past
> debian-l10n-english before the next upload.
That''s great news. I think that letting -l10n-english have a look at
the
messages is a good idea. By the way, there are some more things that I 
spotted in the code, should I submit a new bug or can I just send the patch 
directly to you or the mailing list?

Regards,
Tobias

-- 
Tobias Toedter   | Right now I''m having amnesia and deja vu at the
Hamburg, Germany | same time. I think I''ve forgotten this before.

Processing commands for control@bugs.debian.org:
> tags #377387 confirmed pending
Bug#377387: Improvements for the program output
Tags were: patch
Tags added: confirmed, pending
> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)

tags #377387 confirmed pending
thanks

On Sun, Jul 09, 2006 at 07:00:31PM +0200, Marc Haber
wrote:
> I have applied your patch in svn.
Tagging appropriately.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

Your message dated Sun, 16 Jul 2006 23:47:14 -0700
with message-id <E1G2Mss-0004sj-93@spohr.debian.org>
and subject line Bug#377387: fixed in adduser 3.93
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

-------------- next part --------------
An embedded message was scrubbed...
From: Tobias Toedter <t.toedter@gmx.net>
Subject: Improvements for the program output
Date: Sat, 8 Jul 2006 17:56:05 +0200
Size: 26729
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060717/919c2710/attachment-0002.mht
-------------- next part --------------
An embedded message was scrubbed...
From: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Bug#377387: fixed in adduser 3.93
Date: Sun, 16 Jul 2006 23:47:14 -0700
Size: 3294
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060717/919c2710/attachment-0003.mht