Adduser devel - Aug 2006 - Bug#381923: rpcinfo: can''t contact portpammer: RPC: Remote system error - Connection refused

Package: adduser
Version: 3.95
Severity: normal


If the nis-package is installed and available,
/usr/share/perl5/Debian/AdduserCommon.pm
executes ''/usr/bin/rpcinfo -p''.

If portmap isn''t running, rpcinfo returns:

  rpcinfo: can''t contact portmapper: RPC: Remote system error -
Connection refused

Running ''adduser $USERNAME'' prints 3 of those messages:
one for ''Adding user'', one for ''Adding new
group'' and another one
for ''Adding new user ... with group ...''.

Would be nice to improve handling of nis "error messages" as people
seem to interpret the message as a bug.

regards,
-mika-

On Mon, Aug 07, 2006 at 09:59:41PM +0200, Michael Prokop
wrote:
> Would be nice to improve handling of nis "error messages" as
people
> seem to interpret the message as a bug.
And here is the attachment.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835
-------------- next part --------------
Index: debian/changelog
==================================================================---
debian/changelog	(revision 645)
+++ debian/changelog	(working copy)
@@ -1,8 +1,10 @@
 adduser (3.96.0) UNRELEASED; urgency=low
 
   * NOT RELEASED YET
+  * Don''t show rpcinfo -p errors to the user.
+    Thanks to Michael Prokop. Closes: #381923
 
- -- Marc Haber <mh+debian-packages@zugschlus.de>  Mon, 31 Jul 2006
07:08:01 +0000
+ -- Marc Haber <mh+debian-packages@zugschlus.de>  Tue,  8 Aug 2006
09:07:58 +0000
 
 adduser (3.96) unstable; urgency=low
 
Index: AdduserCommon.pm
==================================================================---
AdduserCommon.pm	(revision 645)
+++ AdduserCommon.pm	(working copy)
@@ -20,8 +20,12 @@
     } elsif(-f "/etc/init.d/nis") {
         $nisconfig = "/etc/init.d/nis";
     }
+    # find out whether a local ypserv is running
+    # We can ditch any rpcinfo error since if the portmapper is nonfunctional,
+    # we couldn''t connect to ypserv anyway. If this assumption is
invalid,
+    # please file a bug and suggest a better way.
     if(defined($nisconfig) && -f "/var/yp/Makefile"
&&
-        -x "/usr/bin/rpcinfo" && grep(/ypserv/,
qx{/usr/bin/rpcinfo -p})) {
+        -x "/usr/bin/rpcinfo" && grep(/ypserv/,
qx{/usr/bin/rpcinfo -p 2>/dev/null})) {
 	open(NISCONFIG, "<$nisconfig");
 	if(grep(/^NISSERVER=master/, <NISCONFIG>)) {
             system("make", "-C", "/var/yp");

Processing commands for control@bugs.debian.org:
> tags #381923 confirmed pending
Bug#381923: rpcinfo: can''t contact portpammer: RPC: Remote system error
- Connection refused
There were no tags set.
Tags added: confirmed, pending
> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)

tags #381923 confirmed pending
thanks

On Mon, Aug 07, 2006 at 09:59:41PM +0200, Michael Prokop
wrote:
> Would be nice to improve handling of nis "error messages" as
people
> seem to interpret the message as a bug.
I have committed the attached fix. Please comment.

I think that it is ok to ignore rpcinfo -p error messages entirely,
since if portmapper is nonfunctional, nobody can connect to ypserv
anyway. The only case where this assumption does not hold is (1)
portmap and ypserv start (2) nscd starts, talks to portmap, connects
to ypserv (3) portmap dies (4) ypserv and nscd keep running. I
consider this case a local failure.

Thanks to Peter Samuelson for his opinion and help in addressing this
issue.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

This one time, at band camp, Marc Haber said:
> And here is the attachment.
> Index: debian/changelog
> ==================================================================> ---
debian/changelog	(revision 645)
> +++ debian/changelog	(working copy)
> @@ -1,8 +1,10 @@
>  adduser (3.96.0) UNRELEASED; urgency=low
>  
>    * NOT RELEASED YET
> +  * Don''t show rpcinfo -p errors to the user.
> +    Thanks to Michael Prokop. Closes: #381923
>  
> - -- Marc Haber <mh+debian-packages@zugschlus.de>  Mon, 31 Jul 2006
07:08:01 +0000
> + -- Marc Haber <mh+debian-packages@zugschlus.de>  Tue,  8 Aug 2006
09:07:58 +0000
>  
>  adduser (3.96) unstable; urgency=low
>  
> Index: AdduserCommon.pm
> ==================================================================> ---
AdduserCommon.pm	(revision 645)
> +++ AdduserCommon.pm	(working copy)
> @@ -20,8 +20,12 @@
>      } elsif(-f "/etc/init.d/nis") {
>          $nisconfig = "/etc/init.d/nis";
>      }
> +    # find out whether a local ypserv is running
> +    # We can ditch any rpcinfo error since if the portmapper is
nonfunctional,
> +    # we couldn''t connect to ypserv anyway. If this assumption is
invalid,
> +    # please file a bug and suggest a better way.
>      if(defined($nisconfig) && -f "/var/yp/Makefile"
&&
> -        -x "/usr/bin/rpcinfo" && grep(/ypserv/,
qx{/usr/bin/rpcinfo -p})) {
> +        -x "/usr/bin/rpcinfo" && grep(/ypserv/,
qx{/usr/bin/rpcinfo -p 2>/dev/null})) {
>  	open(NISCONFIG, "<$nisconfig");
>  	if(grep(/^NISSERVER=master/, <NISCONFIG>)) {
>              system("make", "-C", "/var/yp");
/me approves.
-- 
 -----------------------------------------------------------------
|   ,''''`.                                            Stephen
Gran |
|  : :'' :                                        sgran@debian.org |
|  `. `''                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060808/b7fae5ae/attachment.pgp

Your message dated Tue, 15 Aug 2006 14:17:16 -0700
with message-id <E1GD6Hk-0006aN-Ej@spohr.debian.org>
and subject line Bug#381923: fixed in adduser 3.97
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

-------------- next part --------------
An embedded message was scrubbed...
From: Michael Prokop <mika@grml.org>
Subject: rpcinfo: can''t contact portpammer: RPC: Remote system error -
	Connection refused
Date: Mon, 07 Aug 2006 21:59:41 +0200
Size: 2139
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060815/f5295f79/attachment.mht
-------------- next part --------------
An embedded message was scrubbed...
From: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Bug#381923: fixed in adduser 3.97
Date: Tue, 15 Aug 2006 14:17:16 -0700
Size: 3025
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060815/f5295f79/attachment-0001.mht