llvm dev - Nov 2012 - [LLVMdev] [polly] removing cloog dependence in the testsuite

Hi Tobi,

when polly is configured with isl and without cloog, make polly-test does not
pass cleanly as there are several testcases that use a pass flag that does not
exist in this configuration: -polly-cloog.

I was thinking to address this problem by renaming -polly-cloog and
-polly-codegen-isl to -polly-codegen and making all these tests using
-polly-codegen.

Another option is to disable these tests when cloog is not available, and to
write other tests that will work with -polly-codegen-isl.

Which one do you think is the best to implement?

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation

Hi Tobi,

Sebastian Pop wrote:
> Another option is to disable these tests when cloog is not available, and
to
> write other tests that will work with -polly-codegen-isl.
I think I like this way better.  The attached patches move all the test
dependent on Cloog to be conditionally executed to CLOOG_FOUND.  I am preparing
another patch that will adapt most of the current tests to work with ISL's
code
generator.

Ok to commit?

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-execute-cloog-specific-testcases-only-with-CLOOG_FOU.patch
Type: text/x-diff
Size: 27857 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121127/90982315/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-use-polly-ast-instead-of-polly-cloog.patch
Type: text/x-diff
Size: 11759 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121127/90982315/attachment-0001.patch>

Hi Tobi,

Sebastian Pop wrote:
> Sebastian Pop wrote:
> > Another option is to disable these tests when cloog is not available,
and to
> > write other tests that will work with -polly-codegen-isl.
> 
> I think I like this way better.  The attached patches move all the test
> dependent on Cloog to be conditionally executed to CLOOG_FOUND.  I am
preparing
> another patch that will adapt most of the current tests to work with
ISL's code
> generator.
See attached the patch that adds to the Isl/CodeGen all the tests that can be
run also with the ISL code generator (the vectorizer tests cannot yet be
executed with the ISL code generator yet: when we enabling the vectorizer with
the ISL codegen we will add them).  All these tests are exact copy of the
Cloog/CodeGen tests adapted to match the output of ISL.

With the 3 patches make polly-test is passing with both configurations enabling
either the cloog codegen and the isl codegen.

Is it ok to commit all these three patches?

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-adapt-cloog-codegen-testcases-to-isl.patch
Type: text/x-diff
Size: 113483 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121128/17fd6b8f/attachment.patch>