llvm dev - Jul 2009 - [LLVMdev] [PATCH] PR4256

Hello,

This patch fixes PR4256.

Regards
-- 
Jakub Staszak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr4256.patch
Type: application/octet-stream
Size: 4308 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090711/cbd8cb9f/attachment.obj>

Hi Jakub, please only use spaces for indentation and
not tabs.  I guess Owen is the right guy to review
this patch.

Ciao,

Duncan.

On Jul 11, 2009, at 3:33 PM, Jakub Staszak wrote:
> Hello,
>
> This patch fixes PR4256.
Thanks Jakub!

This patch does two things: refactoring the sort method, and fixing  
the sort to happen on all paths through the phi translation code.  I  
split them into two patches, the first of which is here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/080852.html

and the bug fix is here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/080851.html

For the bug fix part, I chose to hoist the existing two different  
places that do sort up above all the phi translation stuff.  Since the  
sort has to happen before phi translation anyway, this is simpler and  
more foolproof.  Thank you for your patch, it was a great fix, I hope  
you don't mind that I tweaked it a bit.

-Chris