llvm dev - Jun 2009 - [LLVMdev] [PATH] Fix support for .umul.with.overflow on x86 + fix c binding

Hi,

  The first patch fixes the implementation of umul.with.overflow on x86
which was throwing a 'Cannot yet select' error.
  The second patch fixes the definition of LLVMTypeKind in the C binding by
syncing it with the c++ counterpart.

Please review and commit if it looks ok.

             thanks

                Zoltan
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090601/149fa968/attachment.html>

Hi,

  Forgot the patch...

               Zoltan

On Mon, Jun 1, 2009 at 10:57 PM, Zoltan Varga <vargaz at gmail.com> wrote:
> Hi,
>
>   The first patch fixes the implementation of umul.with.overflow on x86
> which was throwing a 'Cannot yet select' error.
>   The second patch fixes the definition of LLVMTypeKind in the C binding by
> syncing it with the c++ counterpart.
>
> Please review and commit if it looks ok.
>
>              thanks
>
>                 Zoltan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090601/98d2f515/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: umul.diff
Type: text/x-patch
Size: 8009 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090601/98d2f515/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-c.diff
Type: text/x-patch
Size: 607 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090601/98d2f515/attachment-0001.bin>

Zoltan,

No patches are attached anything over 100K or so removed. Best to send to send
any patches to the commits list.

Aaron

  ----- Original Message ----- 
  From: Zoltan Varga 
  To: LLVM Developers Mailing List 
  Sent: Monday, June 01, 2009 9:57 PM
  Subject: [LLVMdev] [PATH] Fix support for .umul.with.overflow on x86 + fix
cbinding


  Hi,

    The first patch fixes the implementation of umul.with.overflow on x86 which
was throwing a 'Cannot yet select' error.
    The second patch fixes the definition of LLVMTypeKind in the C binding by
syncing it with the c++ counterpart.

  Please review and commit if it looks ok.

               thanks

                  Zoltan



------------------------------------------------------------------------------


  _______________________________________________
  LLVM Developers mailing list
  LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
  http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090601/b4082189/attachment.html>

On Mon, Jun 1, 2009 at 2:44 PM, Zoltan Varga<vargaz at gmail.com>
wrote:
> Hi,
>
>   Forgot the patch...
The patch for umul is simply wrong; try reading the Intel x86
instruction manual.

-Eli