llvm dev - Mar 2009 - [LLVMdev] automatic discovery of new CMake projects

Hi all,

 

The suggested patch enables addition of all subdirectories of
llvm/projects to CMake build.

It somewhat simplifies the process of creating new projects that use
CMake instead of make, eliminating the need of editing
llvm/CMakeLists.txt and llvm/projects/CMakeLists.txt.

 

Best regards,

Victor

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090304/4b3743ad/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_projects.patch
Type: application/octet-stream
Size: 682 bytes
Desc: cmake_projects.patch
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090304/4b3743ad/attachment.obj>

Sorry, attached the wrong patch last time.

 

________________________________

From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu]
On Behalf Of Viktar Zviarovich
Sent: 04 March 2009 14:19
To: llvmdev at cs.uiuc.edu
Subject: [LLVMdev] automatic discovery of new CMake projects

 

Hi all,

 

The suggested patch enables addition of all subdirectories of
llvm/projects to CMake build.

It somewhat simplifies the process of creating new projects that use
CMake instead of make, eliminating the need of editing
llvm/CMakeLists.txt and llvm/projects/CMakeLists.txt.

 

Best regards,

Victor

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090304/94809055/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_projects.patch
Type: application/octet-stream
Size: 717 bytes
Desc: cmake_projects.patch
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090304/94809055/attachment.obj>

"Viktar Zviarovich" <Viktar.Zviarovich at brunel.ac.uk> writes:
> The suggested patch enables addition of all subdirectories of
> llvm/projects to CMake build.
>
> It somewhat simplifies the process of creating new projects that use
> CMake instead of make, eliminating the need of editing
> llvm/CMakeLists.txt and llvm/projects/CMakeLists.txt.
This is not considered a good practice. The reason is that it requires
an explicit cmake invocation everytime you add or remove a new
project. This can be obvious for you (the person who creates the
project) but someone updating his svn working copy would not notice that
an explicit re-run of cmake is required.

OTOH, if the projects/ dir is some kind of "local playground" for LLVM
users, it wouldn't a serious problem, as the changes made there are not
intended to be committed to the svn server. But anyways you should
mention the requirement for the explicit cmake invocation on
projects/CMakeLists.txt or the on the LLVM CMake doc (or on both).

-- 
Oscar