llvm dev - Jul 2008 - [LLVMdev] [PATCH] patch to compile llvm-gcc using nightly tester script(NewNightlyTester.pl)

hello every body.

Here with I have attached the patch which compile the llvm-gcc using nightly
tester script. This patch add the following capabilities to the
NewNightlyTester.pl script.

1. Checkout the llvm-gcc4.2 source from the SVN.
2. Compile the checkout llvm-gcc4.2 source tree.
3. Gather the configure/make out put informations.
4. Add the (3) informations to the %hash_of_data hash to be posted to the
server, of course for further processing.

Please review the patch and let me know your comments. There are few small
TODOs (ex: get the LOC of llvm-gcc etc..,) to be added. I'll update the
patch with that soon.

Thank you

-Rajika

-- 
comp.lang.c - http://groups.google.com/group/comp.lang.c/topics
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080706/e573ec17/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NewNightlyTest.patch
Type: application/octet-stream
Size: 14121 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080706/e573ec17/attachment.obj>

hello everybody,

I have added few improvements to my patch. Please review the new patch
directly.
Thanks!

-Rajika

On Sun, Jul 6, 2008 at 9:17 PM, Rajika Kumarasiri <rajikacc at gmail.com>
wrote:
> hello every body.
>
> Here with I have attached the patch which compile the llvm-gcc using
> nightly tester script. This patch add the following capabilities to the
> NewNightlyTester.pl script.
>
> 1. Checkout the llvm-gcc4.2 source from the SVN.
> 2. Compile the checkout llvm-gcc4.2 source tree.
> 3. Gather the configure/make out put informations.
> 4. Add the (3) informations to the %hash_of_data hash to be posted to the
> server, of course for further processing.
>
> Please review the patch and let me know your comments. There are few small
> TODOs (ex: get the LOC of llvm-gcc etc..,) to be added. I'll update the
> patch with that soon.
>
> Thank you
>
> -Rajika
>
> --
> comp.lang.c - http://groups.google.com/group/comp.lang.c/topics



-- 
comp.lang.c - http://groups.google.com/group/comp.lang.c/topics
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080707/77cca6aa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NewNightlyTest_v2.patch
Type: application/octet-stream
Size: 14070 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080707/77cca6aa/attachment.obj>

On Mon, Jul 7, 2008 at 11:10 AM, Rajika Kumarasiri <rajikacc at gmail.com>
wrote:
> hello everybody,
>
> I have added few improvements to my patch. Please review the new patch
> directly.
> Thanks!
>
Hi Rajika,

A few stylistic comments. I'll let others comment on the algorithm for now:

     if ($VERBOSE) {
       print "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; "
.
-            "$SVNCMD/test-suite/trunk llvm-test ) > $COLog
2>&1\n";
+            "$SVNCMD/test-suite/trunk llvm-test ; cd ../../;" .
+	    "$SVNCMD/llvm-gcc-4.2/trunk dst-directory ) > $COLog
2>&1\n";
     }
     system "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; " .
-          "$SVNCMD/test-suite/trunk llvm-test ) > $COLog
2>&1\n";
+          "$SVNCMD/test-suite/trunk llvm-test ; cd ../../;" .
+	  "$SVNCMD/llvm-gcc-4.2/trunk dst-directory ) > $COLog
2>&1\n";

This could be done with something like this:

     my $cmd = "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ;
" .
              "$SVNCMD/llvm-gcc-4.2/trunk dst-directory; " .
              "cd llvm/projects; " .
              "$SVNCMD/test-suite/trunk llvm-test ) > $COLog
2>&1\n";

     print $cmd if ($VERBOSE);
     system $cmd;

This could be done in other spots that do similar things as well.
Also, why not name the LLVM-GCC source directory something other than
"dst-directory"? Maybe "llvm-gcc.src" or similar? You add a
few
extraneous newlines in the code. Please remove those.

-    my $CVSCMD = "$NICE cvs $CVSOPT -d $CVSRootDir co -P $CVSCOOPT";
+    my $CVSCMD = "$NICE cvs $CVSOPT -d $CVSRootDir co -P $CVSCOOPT";
# TODO, do we still maintain the CVS tree ?

80-column violation here and in other places. Put the comment before
here. (And, no, we don't maintain the CVS tree anymore.)

-bw

Rajika,

A couple of comments:

- You should provide a way to specify where llvm-gcc is built (just like 
llvm).

- I would highly recommend allowing the user to only update llvm-gcc and 
not check it out from scratch each time. Checking out llvm-gcc is very 
time consuming. You would need to make sure that llvm and llvm-gcc have 
the same rev number and nuke the llvm obj/install dirs so you get a clean 
build. Sure svn issues can happen, but they are rare and your script 
changes should be able to catch those errors.

- Remove the cvs stuff, its dead. Feel free to clean up the 
script and remove ALL cvs stuff.

- I think if LLVM_GCC_CONFIGURE is set and the flag -nollvmgcc is not set,
   you should throw an error.

- You should not try to add the configure options yourself, this is not 
worth it in my opinion (maybe in the future if you want to base it off the 
target triple or something) but for now.. keep it simple. You should only 
add the --enable-llvm since only the script knows where its built.

- What happens if LLVMGCCDIR is set? It will use that over the llvm-gcc 
you have built. In fact, I don't think you have reconfigured llvm at all 
after building llvm-gcc.

- Checkout to something more meaningful then dst-directory.

- We don't care about warnings, file sizes or loc of llvm-gcc. If you want
   to keep any stats you can keep track of config, build times, and build
   status. The rest is stuff we don't really want to track in the database
  (too much info!).

Also, how have you tested this?? Where is the patch to the DB schema and 
accept scripts?

-Tanya

On Mon, 7 Jul 2008, Rajika Kumarasiri wrote:
> hello everybody,
>
> I have added few improvements to my patch. Please review the new patch
> directly.
> Thanks!
>
> -Rajika
>
> On Sun, Jul 6, 2008 at 9:17 PM, Rajika Kumarasiri <rajikacc at
gmail.com>
> wrote:
>
>> hello every body.
>>
>> Here with I have attached the patch which compile the llvm-gcc using
>> nightly tester script. This patch add the following capabilities to the
>> NewNightlyTester.pl script.
>>
>> 1. Checkout the llvm-gcc4.2 source from the SVN.
>> 2. Compile the checkout llvm-gcc4.2 source tree.
>> 3. Gather the configure/make out put informations.
>> 4. Add the (3) informations to the %hash_of_data hash to be posted to
the
>> server, of course for further processing.
>>
>> Please review the patch and let me know your comments. There are few
small
>> TODOs (ex: get the LOC of llvm-gcc etc..,) to be added. I'll update
the
>> patch with that soon.
>>
>> Thank you
>>
>> -Rajika
>>
>> --
>> comp.lang.c - http://groups.google.com/group/comp.lang.c/topics
>
>
>
>
>