llvm dev - Mar 2008 - [LLVMdev] Build problem in TOT llvm

I'm getting a lot of these from TOT make:

/Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h: In  
instantiation of 'llvm::LoopInfoBase<llvm::BasicBlock>':
/Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:886:    
instantiated from here
/Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:573:  
warning: 'class llvm::LoopInfoBase<llvm::BasicBlock>' has virtual
functions but non-virtual destructor

On Mar 17, 2008, at 5:46 PM, Dale Johannesen wrote:
> I'm getting a lot of these from TOT make:
>
> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h: In
> instantiation of 'llvm::LoopInfoBase<llvm::BasicBlock>':
> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:886:
> instantiated from here
> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:573:
> warning: 'class llvm::LoopInfoBase<llvm::BasicBlock>' has
virtual
> functions but non-virtual destructor
Weird, I did not get this error. If following helps, please apply.
Thanks,

-
Devang



Index: LoopInfo.h
==================================================================--- LoopInfo.h
(revision 48476)
+++ LoopInfo.h	(working copy)
@@ -580,9 +580,6 @@
    LoopInfoBase() { }
    ~LoopInfoBase() { releaseMemory(); }

-  /// isAnalysis - Return true if this pass is  implementing an  
analysis pass.
-  virtual bool isAnalysis() const { return true; }
-
    void releaseMemory() {
      for (typename std::vector<LoopBase<BlockT>* >::iterator I     
TopLevelLoops.begin(), E = TopLevelLoops.end(); I != E; ++I)
@@ -922,6 +919,9 @@
      return LI->isLoopHeader(BB);
    }

+  /// isAnalysis - Return true if this pass is  implementing an  
analysis pass.
+  bool isAnalysis() const { return true; }
+
    /// runOnFunction - Calculate the natural loop information.
    ///
    virtual bool runOnFunction(Function &F);

On Mar 17, 2008, at 6:22 PM, Devang Patel wrote:
>
> On Mar 17, 2008, at 5:46 PM, Dale Johannesen wrote:
>
>> I'm getting a lot of these from TOT make:
>>
>> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h: In
>> instantiation of 'llvm::LoopInfoBase<llvm::BasicBlock>':
>> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:886:
>> instantiated from here
>> /Volumes/MacOS9/gcc/llvm/include/llvm/Analysis/LoopInfo.h:573:
>> warning: 'class llvm::LoopInfoBase<llvm::BasicBlock>' has
virtual
>> functions but non-virtual destructor
>
> Weird, I did not get this error. If following helps, please apply.
> Thanks,
It does help, I have checked it in.  Thanks.