APInt::getBitsSet's loBit and hiBit arguments describe a range that's inclusive on both ends. Would anyone mind if we change it to be a "half-open" range, meaning exclusive on the high end? Currently every caller (including several new ones in some code I'm writing right now) does a subtract by one to adjust for the current behavior. And the implementation does an add by one for its part. It would be simpler on both sides to just define the hiBit as being one past the last bit set. Dan
On Feb 11, 2008, at 3:47 PM, Dan Gohman wrote:> APInt::getBitsSet's loBit and hiBit arguments describe a range that's > inclusive > on both ends. Would anyone mind if we change it to be a "half-open" > range, > meaning exclusive on the high end?I think that is much more consistent with the way the STL works, and is thus less surprising, go for it! -Chris