I have been runing CC.rb for a couple of days now. I notice that the dashboard claims that a build passed even when a few of my unit tests fail. I would like to enforce the condition that ALL tests need to pass, for the build to be successful. Is there a way to do that? I''m running ver 1.2.1 Thanks, Arun Theivendirarajah
On Feb 11, 2008 5:30 PM, Arun Theivendirarajah <arun at trusera.com> wrote:> I have been runing CC.rb for a couple of days now. I notice that the > dashboard claims that a build passed even when a few of my unit tests > fail. I would like to enforce the condition that ALL tests need to > pass, for the build to be successful. > > Is there a way to do that?Yup. Upgrade Ruby to 1.8.6 patchlevel 111, or downgrade to 1.8.5. This is a known bug in some of the earlier 1.8.6 releases. -- Alexey Verkhovsky CruiseControl.rb [http://cruisecontrolrb.thoughtworks.com] RubyWorks [http://rubyworks.thoughtworks.com]
>>* I have been runing CC.rb for a couple of days now. I notice that the*>>* dashboard claims that a build passed even when a few of my unit tests *>>* fail. I would like to enforce the condition that ALL tests need to *>>* pass, for the build to be successful. *>>* *>>* Is there a way to do that? *>> Yup. Upgrade Ruby to 1.8.6 patchlevel 111, or downgrade to 1.8.5. This > is a known bug in some of the earlier 1.8.6 releases.i just upgraded to 1.8.6 patch level 111 and i still seem to be experiencing the same thing... Finished in 6.445108 seconds 450 examples, 2 failures, 91 pending rake aborted! yet, cruisecontrolrb still reports success. any ideas? Thanks, David Meiners -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/cruisecontrolrb-users/attachments/20080226/ad57de84/attachment.html
On Tue, Feb 26, 2008 at 11:15 PM, itsdave101 at gmail.com <itsdave101 at gmail.com> wrote:> Finished in 6.445108 seconds > > 450 examples, 2 failures, 91 pending > rake aborted! > > yet, cruisecontrolrb still reports success. > > > any ideas?Look closely at the return code of your rake tasks, or however you invoke your tests/specs. Try running them manually, outside of cruise, and inspect the return code ($?). See if you can track down the false positive return code. -- Chad
On Tue, Feb 26, 2008 at 11:29 PM, Chad Woolley <thewoolleyman at gmail.com> wrote:> On Tue, Feb 26, 2008 at 11:15 PM, itsdave101 at gmail.com > <itsdave101 at gmail.com> wrote: > > Finished in 6.445108 seconds > > > > 450 examples, 2 failures, 91 pending > > rake aborted! > > > > yet, cruisecontrolrb still reports success. > > > > > > any ideas? > > Look closely at the return code of your rake tasks, or however you > invoke your tests/specs. Try running them manually, outside of > cruise, and inspect the return code ($?). See if you can track down > the false positive return code. > > -- ChadI think i figured it out. seems I should be using Rake::Task["spec"].invoke as opposed to system "rake spec" found my answer here: http://railsbros.de/2007/11/19/rake-code-cruise-code-task David.> > _______________________________________________ > Cruisecontrolrb-users mailing list > Cruisecontrolrb-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/cruisecontrolrb-users >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/cruisecontrolrb-users/attachments/20080227/4c6005fe/attachment.html
On Wed, Feb 27, 2008 at 3:33 PM, itsdave101 at gmail.com <itsdave101 at gmail.com> wrote:> I think i figured it out. seems I should be using > > Rake::Task["spec"].invoke > > as opposed to > > system "rake spec" > > found my answer here: > http://railsbros.de/2007/11/19/rake-code-cruise-code-taskHere''s what we do: execute "time rake spec --trace" def execute(cmd) system(cmd) || raise("Build failed") end ..but there are some drawbacks to that, so the Rake::Task.invoke may be better in some cases... BTW I just noticed your ID. Dave''s not here!!! -- Chad
On Wed, Feb 27, 2008 at 4:56 PM, Chad Woolley <thewoolleyman at gmail.com> wrote:> Here''s what we do: > execute "time rake spec --trace"Or you can just use FileUtils::sh() instead of system(). The only catch is that sh() prints out the command before executing it. -- Alexey Verkhovsky CruiseControl.rb [http://cruisecontrolrb.thoughtworks.com] RubyWorks [http://rubyworks.thoughtworks.com]