Hello, with the patches you accepted last week, everything now works with two one-line modifications. One is a missing include in a windows specific platform file and the other is a definition of a symbol I need to trick the linker (as discussed before)... The attached file is the complete diff between my version and the CVS. If you want to put my visual studio project files into the CVS, please tell me where to send them as they're too big to attach to this mail. m. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: diff.txt URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041101/d59f2979/attachment.txt>
If you're getting this error in lib/System/Win32/TimeValue.cpp, then you are not building it correctly. This file is included by lib/System/TimeValue.cpp, which is what you ought to be building. None of the files under Win32 are to be compiled directly; they are all included by files in lib/System. On Mon, 01 Nov 2004 11:14:18 +0100 Morten Ofstad <morten at hue.no> wrote:> Hello, > > with the patches you accepted last week, everything now works with two > one-line modifications. One is a missing include in a windows specific > platform file and the other is a definition of a symbol I need to trick > the linker (as discussed before)... The attached file is the complete > diff between my version and the CVS. > > If you want to put my visual studio project files into the CVS, please > tell me where to send them as they're too big to attach to this mail. > > m. >
Jeff Cohen wrote:> If you're getting this error in lib/System/Win32/TimeValue.cpp, then you are not building it correctly. This file is included by lib/System/TimeValue.cpp, which is what you ought to be building. None of the files under Win32 are to be compiled directly; they are all included by files in lib/System.I probably was building it incorrectly at some point -- now I just removed this line and everything is still working... Sorry for any trouble... m.
On Mon, 1 Nov 2004, Morten Ofstad wrote:> with the patches you accepted last week, everything now works with two > one-line modifications.Great!> One is a missing include in a windows specific > platform file andOkay, as Jeff pointed out, this isn't needed, so not applied.> the other is a definition of a symbol I need to trick the linker (as > discussed before)... The attached file is the complete diff between myApplied: http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041101/020124.html> If you want to put my visual studio project files into the CVS, please > tell me where to send them as they're too big to attach to this mail.I'm not sure what the right thing is to do with these, I will defer to other people more involved with the build to decide. For me, coming up with a way to support both unix-like and windows-like systems in one framework seems best from the maintenance standpoint, but I don't know what the right way is to do this. -Chris -- http://llvm.org/ http://nondot.org/sabre/
We could add the MSVS project files to the repository but I too would like to see a single mechanism for building on all platforms. Someone mentioned using the Boost build system a few weeks ago but I haven't heard anything more on how that effort is going. I also think we can customize our existing makefiles to use the underlying (command oriented) tools under MSVS. We'd still need cygwin for this solution but at least we could compile with an MS compiler. Reid. Chris Lattner wrote:> On Mon, 1 Nov 2004, Morten Ofstad wrote: > >>with the patches you accepted last week, everything now works with two >>one-line modifications. > > > Great! > > >>One is a missing include in a windows specific >>platform file and > > > Okay, as Jeff pointed out, this isn't needed, so not applied. > > >>the other is a definition of a symbol I need to trick the linker (as >>discussed before)... The attached file is the complete diff between my > > > Applied: > http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041101/020124.html > > >>If you want to put my visual studio project files into the CVS, please >>tell me where to send them as they're too big to attach to this mail. > > > I'm not sure what the right thing is to do with these, I will defer to > other people more involved with the build to decide. > > For me, coming up with a way to support both unix-like and windows-like > systems in one framework seems best from the maintenance standpoint, but I > don't know what the right way is to do this. > > -Chris >