Michael Graczyk
2016-Apr-26 03:52 UTC
[opus] opus-tools: Fix potential uninitialized access for set-ctl-int
Here is a simple patch to fix a bug in opusenc's set-ctl-int code -- Thanks, Michael Graczyk -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Fix-potential-uninitialized-access-for-set-ctl-int.patch Type: text/x-patch Size: 992 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20160425/22994ffa/attachment.bin>
Michael Graczyk
2016-Apr-26 03:55 UTC
[opus] opus-tools: Fix potential uninitialized access for set-ctl-int
Since the attachment was not treated as text, here is the patch inline: --- src/opusenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opusenc.c b/src/opusenc.c index 0f83194..cc84ed1 100644 --- a/src/opusenc.c +++ b/src/opusenc.c @@ -776,7 +776,7 @@ int main(int argc, char **argv) } }else if(target<header.nb_streams){ OpusEncoder *oe; - opus_multistream_encoder_ctl(st,OPUS_MULTISTREAM_GET_ENCODER_STATE(i,&oe)); + opus_multistream_encoder_ctl(st,OPUS_MULTISTREAM_GET_ENCODER_STATE(target,&oe)); ret=opus_encoder_ctl(oe, opt_ctls_ctlval[i*3+1],opt_ctls_ctlval[i*3+2]); if(ret!=OPUS_OK){ fprintf(stderr,"Error opus_encoder_ctl(st[%d],%d,%d) returned: %s\n",target,opt_ctls_ctlval[i*3+1],opt_ctls_ctlval[i*3+2],opus_strerror(ret)); -- How do you guys prefer to receive patches? I'm fearful that Gmail will mangle them if I send them inline line this. On Mon, Apr 25, 2016 at 8:52 PM, Michael Graczyk <mgraczyk at google.com> wrote:> Here is a simple patch to fix a bug in opusenc's set-ctl-int code > > -- > > Thanks, > Michael Graczyk-- Thanks, Michael Graczyk
Mark Harris
2016-Nov-11 10:52 UTC
[opus] opus-tools: Fix potential uninitialized access for set-ctl-int
On Mon, Apr 25, 2016 at 8:52 PM, Michael Graczyk <mgraczyk at google.com> wrote:> Here is a simple patch to fix a bug in opusenc's set-ctl-int codeThanks for the patch! Applied.> How do you guys prefer to receive patches?git send-email, or git format-patch sent as an attachment, should keep the patch from getting mangled. - Mark
Seemingly Similar Threads
- [opus-tools] [PATCH] Add channel-mapping argument to force channel mapping
- Opus multi-stream/surround: Audio corruption on decoded content
- [PATCH] Add Functions to Create Ambisonic Multistream Encoder
- Channel Mapping Family for Ambisonics
- [PATCH] Fix ambisonics bitrate when bitrate_bps is OPUS_AUTO