It seems to me that the man page is not complete. Personally, I had to read the code to understand. Propose to amend paragraph of included files on: -i GUEST-PATH=HOST-PATH, --include GUEST-PATH=HOST-PATH File (HOST-PATH) to copy into custom dir (GUEST-PATH). -I HOST-PATH, --includefile=HOST-PATH Copy all files listed in inputfile into the appropriate temporary sandbox directories. File should contain a line like: GUEST-PATH=HOST-PATH Directory (or subdirectory) of GUEST-PATH path must to exist in the guest filesystem (use --mount) Maybe I misunderstood how to use inclusion, but it says even more about what leadership should be written in detail. P.S. On the use of the network too. -- F1ash
On 12/05/2013 11:25 AM, Fl@sh wrote:> It seems to me that the man page is not complete._which_ manpage?> Personally, I had to read the code to understand. Propose to > amend paragraph of included files on: > > -i GUEST-PATH=HOST-PATH, --include GUEST-PATH=HOST-PATH > File (HOST-PATH) to copy into custom dir > (GUEST-PATH). > > -I HOST-PATH, --includefile=HOST-PATH > Copy all files listed in inputfile into the > appropriate temporary sandbox directories. File should > contain a line like: GUEST-PATH=HOST-PATHIt sounds like you are complaining about libvirt-sandbox? Are you comfortable providing your proposed improvements as an actual patch against the source code?> > Directory (or subdirectory) of GUEST-PATH path > must to exist in the guest filesystem (use --mount) > > Maybe I misunderstood how to use inclusion, but it says even > more about what leadership should be written in detail. > P.S. On the use of the network too.Again, providing the actual content you want to see, instead of making us guess, will help this get resolved faster. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Thu, 05 Dec 2013 12:28:27 -0700 Eric Blake <eblake@redhat.com> wrote:> On 12/05/2013 11:25 AM, Fl@sh wrote: > > It seems to me that the man page is not complete. > > _which_ manpage? > > > Personally, I had to read the code to understand. Propose to > > amend paragraph of included files on: > > > > -i GUEST-PATH=HOST-PATH, --include GUEST-PATH=HOST-PATH > > File (HOST-PATH) to copy into custom dir > > (GUEST-PATH). > > > > -I HOST-PATH, --includefile=HOST-PATH > > Copy all files listed in inputfile into the > > appropriate temporary sandbox directories. File should > > contain a line like: GUEST-PATH=HOST-PATH > > It sounds like you are complaining about libvirt-sandbox? Are you > comfortable providing your proposed improvements as an actual patch > against the source code? > > > > > Directory (or subdirectory) of GUEST-PATH path > > must to exist in the guest filesystem (use --mount) > > > > Maybe I misunderstood how to use inclusion, but it says even > > more about what leadership should be written in detail. > > P.S. On the use of the network too. > > Again, providing the actual content you want to see, instead of making > us guess, will help this get resolved faster. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >Ups, sorry... Virt-sandbox man page. Instead, this paragraph: "-I HOST-PATH, --includefile=HOST-PATH Copy all files listed in inputfile into the appropriate temporary sandbox directories. " -- F1ash
Yet one question about virt-sandbox: Man page say about 3 type of mounting (host-bind,host-image,guest-bind). These types can be used together (in combination) or they can be used only except two other? -- Fl@sh
On Thu, Dec 05, 2013 at 10:25:09PM +0400, Fl@sh wrote:> It seems to me that the man page is not complete. > Personally, I had to read the code to understand. Propose to > amend paragraph of included files on: > > -i GUEST-PATH=HOST-PATH, --include GUEST-PATH=HOST-PATH > File (HOST-PATH) to copy into custom dir > (GUEST-PATH). > > -I HOST-PATH, --includefile=HOST-PATH > Copy all files listed in inputfile into the > appropriate temporary sandbox directories. File should > contain a line like: GUEST-PATH=HOST-PATH > > Directory (or subdirectory) of GUEST-PATH path > must to exist in the guest filesystem (use --mount) > > Maybe I misunderstood how to use inclusion, but it says even > more about what leadership should be written in detail. > P.S. On the use of the network too.Thanks for the feedback - could I convince you to file bugs about these requests, so that we don't loose track of them. http://sandbox.libvirt.org/bugs/#report Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Yet one question about "-I"-key in virt-sandbox manpage: Which is format for files listed in inputfile ? Also: manpage say, that this files will to copied "into the appropriate temporary sandbox directories". Which is a directories (in guest /tmp only or another guest dirs too), how & where they are specified? -- Fl@sh