CPAN::Meta::Spec defines the license value must be an array reference.
However current Build.PL uses simple scalar. This breaks generating
META.* files which breaks tests with recent Module::Build 0.4205.
https://bugzilla.redhat.com/show_bug.cgi?id=1083430
Signed-off-by: Petr Písař <ppisar@redhat.com>
---
Build.PL | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Build.PL b/Build.PL
index 55cee55..0ccace3 100644
--- a/Build.PL
+++ b/Build.PL
@@ -316,7 +316,7 @@ my $build = $class->new (
script_files => [ 'v2v/virt-v2v.pl',
'p2v/server/virt-p2v-server.pl' ],
meta_add => {
resources => {
- license => "http://www.gnu.org/licenses/gpl.html",
+ license => [ "http://www.gnu.org/licenses/gpl.html" ],
homepage =>
"http://people.redhat.com/mbooth/virt-v2v/",
repository => "git://git.fedorahosted.org/virt-v2v.git",
MailingList =>
"http://www.redhat.com/mailman/listinfo/libguestfs",
--
1.9.3
Richard W.M. Jones
2014-Jun-27 15:49 UTC
Re: [Libguestfs] [PATCH] The license metadata must be a list
On Fri, Jun 27, 2014 at 05:37:53PM +0200, Petr Písař wrote:> CPAN::Meta::Spec defines the license value must be an array reference. > However current Build.PL uses simple scalar. This breaks generating > META.* files which breaks tests with recent Module::Build 0.4205. > > https://bugzilla.redhat.com/show_bug.cgi?id=1083430 > Signed-off-by: Petr Písař <ppisar@redhat.com> > --- > Build.PL | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Build.PL b/Build.PL > index 55cee55..0ccace3 100644 > --- a/Build.PL > +++ b/Build.PL > @@ -316,7 +316,7 @@ my $build = $class->new ( > script_files => [ 'v2v/virt-v2v.pl', 'p2v/server/virt-p2v-server.pl' ], > meta_add => { > resources => { > - license => "http://www.gnu.org/licenses/gpl.html", > + license => [ "http://www.gnu.org/licenses/gpl.html" ], > homepage => "http://people.redhat.com/mbooth/virt-v2v/", > repository => "git://git.fedorahosted.org/virt-v2v.git", > MailingList => "http://www.redhat.com/mailman/listinfo/libguestfs",Thanks - I have pushed this to the (old) virt-v2v repository. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html