Mike Latimer
2014-Jan-03 20:37 UTC
[Libguestfs] [PATCH] virt-v2v: Fix typo in Windows conversion warning message
--- lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 765ed9f..59d273f 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm +++ b/lib/Sys/VirtConvert/Converter/Windows.pm @@ -338,7 +338,7 @@ sub _prepare_virtio_drivers 'configured with a {block} block storage '. 'adapter, but no driver will be installed for '. 'it. If the {block} driver is not already '. - 'installed in the guest, it will fail to boot.'. + 'installed in the guest, it will fail to boot.', block => $block); } -- 1.8.1.4
Matthew Booth
2014-Jan-07 10:51 UTC
Re: [Libguestfs] [PATCH] virt-v2v: Fix typo in Windows conversion warning message
On 03/01/14 20:37, Mike Latimer wrote:> --- > lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm > index 765ed9f..59d273f 100644 > --- a/lib/Sys/VirtConvert/Converter/Windows.pm > +++ b/lib/Sys/VirtConvert/Converter/Windows.pm > @@ -338,7 +338,7 @@ sub _prepare_virtio_drivers > 'configured with a {block} block storage '. > 'adapter, but no driver will be installed for '. > 'it. If the {block} driver is not already '. > - 'installed in the guest, it will fail to boot.'. > + 'installed in the guest, it will fail to boot.', > block => $block); > } > >You'd think syntax checking would catch this sort of bug :/ ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
Reasonably Related Threads
- [PATCH] virt-v2v: Check for firstboot before unconfiguring XenPV
- [PATCH] virt-v2v: Default to non-virtio drivers if driver path is missing
- [PATCH] virt-v2v: Catch invalid initrd path
- [PATCH 0/4] virt-v2v: Convert RedHat.pm to Linux.pm
- Re: [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support