netfilter buglog - Nov 2018 - [Bug 1291] New: iptables 1.8.0+ no longer builds against kernel 3.10.108

https://bugzilla.netfilter.org/show_bug.cgi?id=1291

            Bug ID: 1291
           Summary: iptables 1.8.0+ no longer builds against kernel
                    3.10.108
           Product: iptables
           Version: unspecified
          Hardware: arm
                OS: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: iptables
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: netfilter at nmacleod.com

Since commit 672accf153037c9d9b39f39381e9bc0f2df57c8c ("include: update
kernel
netfilter header files"), iptables no longer builds against kernel
3.10.108.

Building with gcc-8.2.0, glibc-2.28; cross-compiling to arm on Ubuntu x86_64
(LibreELEC toolchain).

The build failure is[2]:

libtool: compile: 
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/toolchain/bin/armv7a-libreelec-linux-gnueabi-gcc
-DHAVE_CONFIG_H -I.
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/libiptc
-I.. -D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT
-DXTABLES_LIBDIR=\"/usr/lib/xtables\" -DXTABLES_INTERNAL -I../include
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/include
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include/uapi
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include/uapi
-I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include
-Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes
-Wredundant-decls -Wshadow -Wstrict-prototypes -Wlogical-op -Winline -pipe
-march=armv7-a -mtune=cortex-a9 -mabi=aapcs-linux -Wno-psabi
-Wa,-mno-warn-deprecated -mcpu=cortex-a9 -mfloat-abi=hard -mfpu=neon-fp16
-fomit-frame-pointer -Wall -pipe -Os -MT libip6tc.lo -MD -MP -MF
.deps/libip6tc.Tpo -c
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/libiptc/libip6tc.c
 -fPIC -DPIC -o .libs/libip6tc.o
In file included from
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/toolchain/armv7a-libreelec-linux-gnueabi/sysroot/usr/include/netinet/ip.h:24,
                 from
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/include/libiptc/ipt_kernel_headers.h:8,
                 from
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/include/libiptc/libiptc.h:6,
                 from
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/iptables-1.8.1/libiptc/libip4tc.c:29:
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include/uapi/linux/in.h:26:3:
error: redeclaration of enumerator 'IPPROTO_IP'
   IPPROTO_IP = 0,  /* Dummy protocol for TCP  */
   ^~~~~~~~~~
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/toolchain/armv7a-libreelec-linux-gnueabi/sysroot/usr/include/netinet/in.h:42:5:
note: previous definition of 'IPPROTO_IP' was here
     IPPROTO_IP = 0,    /* Dummy protocol for TCP.  */
     ^~~~~~~~~~
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/linux-95ba9d626c0fce672caa296f5911ab9190881642/include/uapi/linux/in.h:28:3:
error: redeclaration of enumerator 'IPPROTO_ICMP'
   IPPROTO_ICMP = 1,  /* Internet Control Message Protocol */
   ^~~~~~~~~~~~
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-WeTek_Core.arm-9.0-devel/toolchain/armv7a-libreelec-linux-gnueabi/sysroot/usr/include/netinet/in.h:44:5:
note: previous definition of 'IPPROTO_ICMP' was here
     IPPROTO_ICMP = 1,    /* Internet Control Message Protocol.  */
     ^~~~~~~~~~~~

etc.

Any thoughts, or is 1.8.0+ no longer compatible with older 3.x.y kernels?

Prior to this commmit, iptables does build successfully against 3.10.108.

Thanks
Neil

1.
https://git.netfilter.org/iptables/commit/?id=672accf153037c9d9b39f39381e9bc0f2df57c8c
2. http://ix.io/1re0

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20181107/7f39cddc/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1291

netfilter at nmacleod.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from netfilter at nmacleod.com ---
8d9d7e4b9ef4c6e6abab2cf35c747d7ca36824bd[1] (include: fix build with kernel
headers before 4.2) seems to fix the issue with 3.10.108, and 1.8.2+8d9d7e4b
with kernel 3.10.108 now builds successfully.

This post[2] on the mailing list suggests that an additional patch is required
to build with pre-3.12 kernels, but that doesn't seem to be the case -
I'm able
to build successfully without it.

Marking this as resolved/fixed. Thanks 

1.
https://git.netfilter.org/iptables/commit/?id=8d9d7e4b9ef4c6e6abab2cf35c747d7ca36824bd
2. https://marc.info/?l=netfilter-devel&m=154314679614719&w=2

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20181203/9e62b5ce/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1291

netfilter at nmacleod.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20181225/45e7b53a/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1291

netfilter at nmacleod.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20181225/3f4d1135/attachment.html>