netfilter buglog - Apr 2014 - [Bug 916] New: Build failure on Slackware 14.1 (./configure rejects libreadline.so)

https://bugzilla.netfilter.org/show_bug.cgi?id=916

           Summary: Build failure on Slackware 14.1 (./configure rejects
                    libreadline.so)
           Product: nftables
           Version: unspecified
          Platform: i386
        OS/Version: other
            Status: NEW
          Severity: major
          Priority: P5
         Component: nft
        AssignedTo: pablo at netfilter.org
        ReportedBy: duncan_roe at acslink.net.au
   Estimated Hours: 0.0


Created attachment 440
  --> https://bugzilla.netfilter.org/attachment.cgi?id=440
patch -p0 file

./configure --prefix=/usr --sysconfdir=/etc --mandir=/usr/man --disable-debug

failed with the error

checking for readline in -lreadline... no
configure: error: No suitable version of libreadline found

The problem is that readline needs ncurses, but doesn't drag it in
automatically.
I've attached my patch of configure.ac to check for ncurses. After running
autoconf, nft configured and built fine.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #3 from Pablo Neira Ayuso <pablo at netfilter.org> ---
You have to run:

./autogen.sh

in first place. Then:

./configure

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160309/c52b4a7f/attachment-0001.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #4 from duncan_roe at acslink.net.au ---
I still get this error in git HEAD after doing a pull. Error message exactly as
per original report.

Here's a quick test you can use to determine whether a system will get the
problem:

10:09:50$ findit libreadline.so readline
/usr/lib/libreadline.so: undefined symbol: PC. libreadline.so (dlopen)

"man PC" brings up the curs_termcap(3X) page, dobbing in libncurses:

10:06:18$ findit -lncurses libreadline.so readline
Found readline in libreadline.so at 0xb74b7f40

findit is part of https://github.com/duncan-roe/command_line_tools - no
releases yet so clone it

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160309/300cea6e/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

Piyush Pangtey <gokuvsvegita at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
                 CC|                            |gokuvsvegita at gmail.com

--- Comment #5 from Piyush Pangtey <gokuvsvegita at gmail.com> ---
(In reply to duncan_roe from comment #2)
> configure.ac still doesn't mention ncurses.This only ever was a problem
with
> certain arguments to ./configure, e.g. ./configure --disable-debug. It did
> not break the Slackware build.
> To check whether I could reproduce the problem, I cloned the git repo. When
> I ran autoconfig, I got:
> 
> configure.ac:13: error: possibly undefined macro: AM_INIT_AUTOMAKE
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> configure.ac:30: error: possibly undefined macro: AM_CONDITIONAL
> configure.ac:37: error: possibly undefined macro: AM_PROG_LEX
> 
> 
> When I then ran ./configure --disable-debug, I got:
> configure: error: cannot find install-sh, install.sh, or shtool in
build-aux
> "."/build-aux
> 
> Please advise what I should have run - I'm not a regular user of auto*
Try GNU libtool . (git://git.savannah.gnu.org/libtool.git) 
and run 

$ libtoolize --force

before executing autoconf script.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160310/3f2c5e22/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #6 from duncan_roe at acslink.net.au ---
I still see

checking for readline in -lreadline... no
configure: error: No suitable version of libreadline found

Just to be clear, I ran ./autogen.sh as Pablo Neira Ayuso advised in Comment 3.
After that, there was no console output from autoconfig.

I ran libtoolize --force as Piyush Pangtey advised in comment 5.
The last line output by libtoolize is:
  libtoolize: Remember to add `LT_INIT' to configure.ac.
so I did that:

00:03:12$ git diff     
diff --git a/configure.ac b/configure.ac
index 0d7e6ed..e76e646 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,6 @@
 #                                               -*- Autoconf -*-
 # Process this file with autoconf to produce a configure script.
+LT_INIT

 AC_PREREQ(2.61)

(END)

If I apply  patch_-p0_file (needs fuzz factor 3 now) it all works:

00:25:16$ git checkout -- configure.ac
00:27:14$ cat configure.ac.patch|patch -F 3 -p0
patching file configure.ac
Hunk #1 succeeded at 71 with fuzz 3.
00:27:35$ autoconf
00:27:47$ ./configure --prefix=/usr --sysconfdir=/etc --mandir=/usr/man
--disable-debug
checking build system type... i686-pc-linux-gnu
<SNIP>
nft configuration:
  cli support:                  yes
  enable debugging:             no
  use mini-gmp:                 no
00:27:57$ git diff
diff --git a/configure.ac b/configure.ac
index 0d7e6ed..901c971 100644
--- a/configure.ac
+++ b/configure.ac
@@ -71,6 +71,9 @@ AM_CONDITIONAL([BUILD_PDF], [test "$DBLATEX" ==
"found"])

 # Checks for libraries.
 PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
+AC_CHECK_LIB([ncurses], [tputs], ,
+            AC_MSG_ERROR([No suitable version of libncurses found]))
+
 PKG_CHECK_MODULES([LIBNFTNL], [libnftnl >= 1.0.5])

 AC_ARG_WITH([mini-gmp], [AS_HELP_STRING([--with-mini-gmp],
00:33:15$

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160312/157b9aed/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

JLC <jason.lee.campbell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason.lee.campbell at gmail.co
                   |                            |m

--- Comment #7 from JLC <jason.lee.campbell at gmail.com> ---
I was able to compile in Slackware with the following (as done in the script
for nft from slackbuilds.org):

LDFLAGS="lncurses" ./configure ...

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160531/7a709ff2/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #8 from Pablo Neira Ayuso <pablo at netfilter.org> ---
This is not a direct dependency for us:

# ldd /usr/sbin/nft
        linux-vdso.so.1 (0x00007ffe39dd1000)
        libmnl.so.0 => /lib/x86_64-linux-gnu/libmnl.so.0 (0x00007efc144d1000)
        libnftnl.so.4 => /usr/lib/libnftnl.so.4 (0x00007efc142ad000)
        libreadline.so.6 => /lib/x86_64-linux-gnu/libreadline.so.6
(0x00007efc14062000)
        libgmp.so.10 => /usr/lib/x86_64-linux-gnu/libgmp.so.10
(0x00007efc13ddf000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007efc13a34000)
        libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5
(0x00007efc13809000)
        /lib64/ld-linux-x86-64.so.2 (0x000055cb83049000)

Not sure why you need this in Slackware.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160606/1cd36376/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #9 from duncan_roe at acslink.net.au ---
Comment 7 is right.
Sorry for the noise - I must have tried to use an early version of the
Slackbuild script.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160705/6e12b283/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #10 from Pablo Neira Ayuso <pablo at netfilter.org> ---
OK, thanks for clarifying. Then unless you have any further concern, I'm
closing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160706/b7e0e845/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=916

--- Comment #11 from duncan_roe at acslink.net.au ---
Go ahead and close

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160713/c8c0281b/attachment.html>