netfilter buglog - Jun 2013 - [Bug 827] New: limit: support is broken

https://bugzilla.netfilter.org/show_bug.cgi?id=827

           Summary: limit: support is broken
           Product: nftables
           Version: unspecified
          Platform: x86_64
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: P5
         Component: nft
        AssignedTo: pablo at netfilter.org
        ReportedBy: eric at regit.org
   Estimated Hours: 0.0


In src/netlink-linearize.c we have:
<pre>
static void netlink_gen_limit_stmt(struct netlink_linearize_ctx *ctx,
                   const struct stmt *stmt)
{
    struct nfnl_nft_expr *nle;

    nle = alloc_nft_expr(nfnl_nft_limit_init);
    nfnl_nft_limit_set_rate(nle, stmt->limit.rate);
    nfnl_nft_limit_set_depth(nle, stmt->limit.depth);
    nfnl_nft_rule_add_expr(ctx->nlr, nle);
}
</pre>
but in parser.y we have:
<pre>
limit_stmt        :    LIMIT    RATE    NUM    SLASH    time_unit
                {
                $$ = limit_stmt_alloc(&@$);
                $$->limit.rate    = $3;
                $$->limit.unit    = $5;
            }
            ;
</pre>
So the depth is always 0 and unit is not set.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=827

Phil Oester <netfilter at linuxace.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |netfilter at linuxace.com

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=827

Phil Oester <netfilter at linuxace.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Phil Oester <netfilter at linuxace.com> 2013-10-22
20:24:03 CEST ---
This has been corrected in latest git.  Closing.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.