memcpy_fromiovec is moved to lib/iovec.c. No need to include linux/socket.h for it. Signed-off-by: Asias He <asias at redhat.com> --- drivers/vhost/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index e58cf00..038c242 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -13,7 +13,6 @@ #include <linux/eventfd.h> #include <linux/vhost.h> -#include <linux/socket.h> /* memcpy_fromiovec */ #include <linux/mm.h> #include <linux/mmu_context.h> #include <linux/miscdevice.h> -- 1.8.3.1
From: Asias He <asias at redhat.com> Date: Thu, 15 Aug 2013 11:20:16 +0800> memcpy_fromiovec is moved to lib/iovec.c. No need to include > linux/socket.h for it. > > Signed-off-by: Asias He <asias at redhat.com>You can't do this. Because this file doesn't include the header file that provides the declaration, which is linux/uio.h linux/socket.h includes linux/uio.h, so honestly leaving things the way they are is a 1000 times better than your patch.
On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:> From: Asias He <asias at redhat.com> > Date: Thu, 15 Aug 2013 11:20:16 +0800 > > > memcpy_fromiovec is moved to lib/iovec.c. No need to include > > linux/socket.h for it. > > > > Signed-off-by: Asias He <asias at redhat.com> > > You can't do this. > > Because this file doesn't include the header file that > provides the declaration, which is linux/uio.hvhost.c includes drivers/vhost/vhost.h. In drivers/vhost/vhost.h, we have linux/uio.h included.> linux/socket.h includes linux/uio.h, so honestly leaving > things the way they are is a 1000 times better than your > patch.Vhost is a separate module and a generic infrastructure which is not bound to network anymore. I guess it's better to include the real one instead of the socket one. -- Asias