Syslinux - Jun 2013 - [5.10] PXE + dhcp opts 209, 210 and path issues in tftp/http

On Sat, 08 Jun, at 11:57:34AM, Gene Cumm wrote:
> To minimize impact and convey the extent of the change, perhaps change to
> ';' immediately and make another release, probably 5.20 and this
week.
 
This chunk of ftp_readdir() caught my eye,

		} else if ((p = strchr(buf, ';'))) {
		    /* VMS/Multinet format */
		    if (p > buf+4 && !memcmp(p-4, ".DIR", 4)) {
			type = 'd';
			p -= 4;
		    } else {
			type = 'f';
		    }
		    *p = '\0';
		    name = buf;

Now, I admit to knowing absolutely nothing about VMS pathnames, so is it
possible that someone may want to specify an ftp path that includes a
semi-colon in their PATH directive?

-- 
Matt Fleming, Intel Open Source Technology Center

On 06/10/2013 06:35 AM, Matt Fleming wrote:
> On Sat, 08 Jun, at 11:57:34AM, Gene Cumm wrote:
>> To minimize impact and convey the extent of the change, perhaps change
to
>> ';' immediately and make another release, probably 5.20 and
this week.
>  
> This chunk of ftp_readdir() caught my eye,
> 
> 		} else if ((p = strchr(buf, ';'))) {
> 		    /* VMS/Multinet format */
> 		    if (p > buf+4 && !memcmp(p-4, ".DIR", 4)) {
> 			type = 'd';
> 			p -= 4;
> 		    } else {
> 			type = 'f';
> 		    }
> 		    *p = '\0';
> 		    name = buf;
> 
> Now, I admit to knowing absolutely nothing about VMS pathnames, so is it
> possible that someone may want to specify an ftp path that includes a
> semi-colon in their PATH directive?
> 
VMS pathnames with semicolons are the same as in iso9660 -- version
numbers that are extremely rarely used.  However, since file listings
display them, they have to be stripped off.

So it is probably OK for the four people in the world that might have a
VMS server.

	-hpa

On Mon, 10 Jun, at 07:24:21AM, H. Peter Anvin wrote:
> VMS pathnames with semicolons are the same as in iso9660 -- version
> numbers that are extremely rarely used.  However, since file listings
> display them, they have to be stripped off.
> 
> So it is probably OK for the four people in the world that might have a
> VMS server.
 
Next thing I see is HTTP paths. Problem? We could require that all HTTP
strings are encoded.

-- 
Matt Fleming, Intel Open Source Technology Center