On 03/11/2014 09:38 AM, H. Peter Anvin wrote:> On 03/10/2014 11:21 PM, YunQiang Su wrote: >> From: Dejan Latinovic <Dejan.Latinovic at imgtec.com> > > Description goes here? I think it would be helpful to break this up > into a few patches with descriptions. > >> + unsigned long __f20; >> + unsigned long __f21; >> + unsigned long __f22; >> + unsigned long __f23; >> + unsigned long __f24; >> + unsigned long __f25; >> + unsigned long __f26; >> + unsigned long __f27; >> + unsigned long __f28; >> + unsigned long __f29; >> + unsigned long __f30; >> + unsigned long __f31; >> + unsigned long __fcr31; >> + unsigned long __unused; > > Does it make sense to save all the floating-point state even though > klibc doesn't have any floating point support? > >> +/* >> + * Symbolic register names for 32 bit ABI >> + */ > > 64-bit? >I'm also wondering if it is possible to share some of this with the mips32 implementation... -hpa
Hello, I apologize for a late response. I have crated a new version of patch with mips64 support for klibc. Here are some changes: - archsetjmp.h has been reduced. - Symbolic register names are fixed (asm.h). - Some not needed parts were removed. - crt0.S is fixed to work properly for both shared and static apps. - setjmp.S has been reduced. - Some part are used from mips, to avoid coping over (klibc.ld). This patch is tested with debian klibc version 2.0.3-1 and with last klibc version from: https://git.kernel.org/cgit/libs/klibc/klibc.git/ All created binaries are successfully run. Al tests from ./usr/klibc/tests are successfully run. Any suggestions are welcome. I could provide any additional info if needed. The patch is attached. -------------- next part -------------- A non-text attachment was scrubbed... Name: add-mips64-support.patch Type: text/x-patch Size: 10596 bytes Desc: add-mips64-support.patch URL: <http://www.zytor.com/pipermail/klibc/attachments/20140714/a5dc9e81/attachment.bin>
On 07/14/2014 05:24 AM, Dejan Latinovic wrote:> > > Hello, > I apologize for a late response. > > > I have crated a new version of patch with mips64 support for klibc. > > > Here are some changes: > - archsetjmp.h has been reduced. > - Symbolic register names are fixed (asm.h). > - Some not needed parts were removed. > - crt0.S is fixed to work properly for both shared and static apps. > - setjmp.S has been reduced. > - Some part are used from mips, to avoid coping over (klibc.ld). > > This patch is tested with debian klibc version 2.0.3-1 and > with last klibc version from: > https://git.kernel.org/cgit/libs/klibc/klibc.git/ > > > All created binaries are successfully run. > Al tests from ./usr/klibc/tests are successfully run. > > > Any suggestions are welcome. > I could provide any additional info if needed. >Please don't submit a single monolithic patch. Instead break it down into reasonable subchunks, each with a description. This is the same procedure as for submitting patches to the Linux kernel. -hpa
On 07/14/2014 05:24 AM, Dejan Latinovic wrote:> + # sw is actually two instructions; the first one goes > + # in the branch delay slot > + # XXX: Break this up manually; as it is now it generates warnings. > + sw v0, errno > + li v0, -1 > +1: jr raThe comment doesn't seem to match the code. -hpa