Nouveau - Apr 2014 - [Bug 78116] New: Auto fan speed management doesn't do anything in non critical temperature range (NVC0)

https://bugs.freedesktop.org/show_bug.cgi?id=78116

          Priority: medium
            Bug ID: 78116
          Assignee: nouveau at lists.freedesktop.org
           Summary: Auto fan speed management doesn't do anything in non
                    critical temperature range (NVC0)
        QA Contact: xorg-team at lists.x.org
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: mdop at seznam.cz
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: unspecified
         Component: Driver/nouveau
           Product: xorg

I have Gigabyte GTX 560 Ti Ultra Durable card. (Logs for this issue are same as
in Bug 78106)

1a) When I finish booting, nouveau selects AUTO mode (pwm1_enable: 2) and
set's
the fan power to 55% (pwm1: 55).

1b) Enable manual mode, set pwm1 to 100, enable auto mode.

In both cases I would expect from the AUTO mode to lower PWM to go as low as
pwm1_min if the temperature is low enough. My card temperature is 31-33 ?C but
pwm1 is never lowered in AUTO mode (neither from 55 or 100).

2) On Windows pwm goes as low as pwm1_min (which is 40 by default for GTX 560
Ti but it also works with my modded value of 30). I thought that Nvidia card
can manage it by itself (is it really done by operating system/software?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140430/5902aee0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #1 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Hi Marcel,

Which version of the kernel are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140502/01714d90/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #2 from Marcel Dopita <mdop at seznam.cz> ---
I'm using Arch Linux so I'm on the latest stable: 3.14.2
(3.14.2-1-ARCH).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140503/874f2325/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #3 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #2)
> I'm using Arch Linux so I'm on the latest stable: 3.14.2
(3.14.2-1-ARCH).
Hmm, OK. Can you confirm manual fan management works as expected?

I have just tried on my nvc4 and automatic fan management brings back my fan
speed to 40% from the 100% set manually.

As for your question about fan management being done by the hw or software, it
is always scaled in software (either in an RTOS running in the card or in the
kernel driver). In the fermi family, the first chipsets were actually using a
dedicated hardware chip for fan management (ADT7473) but your card is not one
of them. So, in our case, we run the code in the linux kernel but it will be
moved to the RTOS when I'm done pushing my patches to fix timers and when I
take the time to write the code for fan management.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140503/9c6b051e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #4 from Marcel Dopita <mdop at seznam.cz> ---
Yes, manual control works and fan speed does change accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140509/b5314a46/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #5 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #4)
> Yes, manual control works and fan speed does change accordingly.
Can you load nouveau with the following parameter and send us the kernel logs?

debug="PTHERM=debug"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140510/43bf899b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #6 from Marcel Dopita <mdop at seznam.cz> ---
Created attachment 98820
  --> https://bugs.freedesktop.org/attachment.cgi?id=98820&action=edit
dmesg with PTHERM=debug

Boot with debug parameter, after which I tried case 1b) (switching to manual
mode, changing pwm1 to 100 and switching back to automatic).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140510/afe037ce/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #7 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Thanks Marcel. Can I ask you for your vbios?

http://nouveau.freedesktop.org/wiki/DumpingVideoBios/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140510/1215cb65/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #8 from Marcel Dopita <mdop at seznam.cz> ---
I already attached my bios to bug 78106 if that's ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140510/96497066/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #9 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #8)
> I already attached my bios to bug 78106 if that's ok.
Great, thanks, I'll have a look at both bugs tomorrow :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140510/3b6eadf6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #10 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #9)
> (In reply to comment #8)
> > I already attached my bios to bug 78106 if that's ok.
> 
> Great, thanks, I'll have a look at both bugs tomorrow :)
I can't reproduce the bug, but I'll send you a patch for us to get more
visibility on what's going wrong. Sorry for being so slow :s

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140521/84f9a32e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #11 from Marcel Dopita <mdop at seznam.cz> ---
Thanks for taking a look. I still have older card (GTX 260) so I can try that
(other disto too?) and maybe other cards as well. 
Can you confirm that it actually resets for you fan rpm to pwm 55 (or any other
low/default value) once auto mode is enabled and the previous state was
different/higher (say pwm 100)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140521/b5031b24/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #12 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #11)
> Thanks for taking a look. I still have older card (GTX 260) so I can try
> that (other disto too?) and maybe other cards as well. 
Well, you can try to check if they work but the point remains, your current
card doesn't work and it needs to be fixed.
> Can you confirm that it actually resets for you fan rpm to pwm 55 (or any
> other low/default value) once auto mode is enabled and the previous state
> was different/higher (say pwm 100)?
Yes, I confirm this. We'll check why it doesn't work on your card and
fix it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140521/fcf6032d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #13 from Marcel Dopita <mdop at seznam.cz> ---
Seems that my old card - GTX 260 doesn't support manual mode nor does it
report
any temperature/fan speed. 

[    0.491166] nouveau  [  PTHERM][0000:01:00.0] FAN control: none / external
[    0.491175] nouveau  [  PTHERM][0000:01:00.0] fan management: automatic
[    0.491179] nouveau  [  PTHERM][0000:01:00.0] internal sensor: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140523/26d99059/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #14 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #13)
> Seems that my old card - GTX 260 doesn't support manual mode nor does
it
> report any temperature/fan speed. 
> 
> [    0.491166] nouveau  [  PTHERM][0000:01:00.0] FAN control: none /
external
> [    0.491175] nouveau  [  PTHERM][0000:01:00.0] fan management: automatic
> [    0.491179] nouveau  [  PTHERM][0000:01:00.0] internal sensor: yes
It doesn't surprise me. However, it should find an external temperature
sensor
and fan management chip (the ADT7473), can you confirm that or paste your logs
here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140524/3b03e87e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #15 from Marcel Dopita <mdop at seznam.cz> ---
I put logs into separate bug 79204 not to clutter this not related issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/4234f0dc/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #16 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #15)
> I put logs into separate bug 79204 not to clutter this not related issue.
Perfect!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/d7ce4598/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #17 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Created attachment 99775
  --> https://bugs.freedesktop.org/attachment.cgi?id=99775&action=edit
drm/nouveau/therm/fan: add debug information in fan_update()

Please add this patch and send me the dmesg output (add the debug info for
ptherm).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/1d0d6549/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #18 from Marcel Dopita <mdop at seznam.cz> ---
Created attachment 99782
  --> https://bugs.freedesktop.org/attachment.cgi?id=99782&action=edit
dmesg test after patch

I had to modify the patch a bit as in my source there were goto's instead of
returns (I'm not sure what's newer, I used the source in Arch Build
System).
However it applied correctly as I checked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/d25a0f43/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #19 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Created attachment 99790
  --> https://bugs.freedesktop.org/attachment.cgi?id=99790&action=edit
Please patch -p1 < additional_debug.patch

Hmm, seems like the problem is not where I thought it was. Let's see
what's the
output with this patch applied!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/11b270dc/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #20 from Marcel Dopita <mdop at seznam.cz> ---
(In reply to comment #19)
> Hmm, seems like the problem is not where I thought it was. Let's see
what's
> the output with this patch applied!
I cannot compile because of following error:

In file included from drivers/gpu/drm/nouveau/core/include/core/object.h:5:0,
                 from drivers/gpu/drm/nouveau/core/subdev/therm/base.c:25:
drivers/gpu/drm/nouveau/core/subdev/therm/base.c: In function
?nouveau_therm_update?:
drivers/gpu/drm/nouveau/core/subdev/therm/base.c:136:25: error: ?struct
nvbios_therm_fan? has no member named ?fan_mode?
    duty, priv->fan->bios.fan_mode);
                         ^
drivers/gpu/drm/nouveau/core/include/core/printk.h:14:45: note: in definition
of macro ?nv_printk?
   nv_printk_(nv_object(o), NV_DBG_##l, f, ##a);                  \
                                             ^
drivers/gpu/drm/nouveau/core/subdev/therm/base.c:132:2: note: in expansion of
macro ?nv_debug?
  nv_debug(therm, "nouveau_therm_update; mode = %d, poll = %d, "
  ^
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_cm.o
  CC [M]  drivers/infiniband/hw/qib/qib_ud.o
scripts/Makefile.build:308: recipe for target
'drivers/gpu/drm/nouveau/core/subdev/therm/base.o' failed
make[4]: *** [drivers/gpu/drm/nouveau/core/subdev/therm/base.o] Error 1
scripts/Makefile.build:455: recipe for target 'drivers/gpu/drm/nouveau'
failed
make[3]: *** [drivers/gpu/drm/nouveau] Error 2
scripts/Makefile.build:455: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:455: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/517680b5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #21 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Could you try using a 3.15-rcX kernel instead of a 3.14?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140525/65e90deb/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #22 from Marcel Dopita <mdop at seznam.cz> ---
(In reply to comment #21)
> Could you try using a 3.15-rcX kernel instead of a 3.14?
It works correctly under 3.15-rc7 (fan starts at lowest pwm1 value and re-sets
after re-enabling auto mode) so I guess that it resolves this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140526/015eb185/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #23 from Emil Velikov <emil.l.velikov at gmail.com> ---
(In reply to comment #22)
> (In reply to comment #21)
> > Could you try using a 3.15-rcX kernel instead of a 3.14?
> 
> It works correctly under 3.15-rc7 (fan starts at lowest pwm1 value and
> re-sets after re-enabling auto mode) so I guess that it resolves this
issue.
Most likely fixed with the following

commit dcd9262b3baf881285e9e0fd5459d54723cc992e
Author: Ben Skeggs <bskeggs at redhat.com>
Date:   Mon Mar 24 13:34:47 2014 +1000

    drm/nouveau/therm: check for sensor presence with requested mode, not
current


perhaps we can forward it to linus-stable ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140526/e763d7c1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #24 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #22)
> (In reply to comment #21)
> > Could you try using a 3.15-rcX kernel instead of a 3.14?
> 
> It works correctly under 3.15-rc7 (fan starts at lowest pwm1 value and
> re-sets after re-enabling auto mode) so I guess that it resolves this
issue.
I'm glad it works! That means we fixed all the bugs you reported (with the
exception of the i2c issue that still needs to be pulled by Ben before I can
close it)? If so, I would like to thank you again for being an exemplary bug
reporter!

Sorry for being slow to answer to your bug reports though...

Should we close this bug now?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140526/ce69c694/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

--- Comment #25 from Marcel Dopita <mdop at seznam.cz> ---
Yep, switch it to appropriate state, please (I'm not sure if resolved is
right
as it already was fixed in rc). I will recheck it once stable is out. Thanks
Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140526/c0d0bf28/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78116

Martin Peres <martin.peres at ensi-bourges.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #26 from Martin Peres <martin.peres at ensi-bourges.fr> ---
Closing this bug as fixed then!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140526/0ccf478c/attachment-0001.html>