Nouveau - Mar 2008 - [Bug 14858] New: Build fix for FreeBSD

http://bugs.freedesktop.org/show_bug.cgi?id=14858

           Summary: Build fix for FreeBSD
           Product: xorg
           Version: git
          Platform: x86-64 (AMD64)
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: pawel.worach at gmail.com
         QAContact: xorg-team at lists.x.org


nv_bios.c:26:22: error: byteswap.h: No such file or directory

bswap and friends are defined in endian.h (on freebsd) which is pulled in by
X11/Xarch.h. This should fix the build on netbsd too.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858





--- Comment #1 from Pawel Worach <pawel.worach at gmail.com>  2008-03-06
11:39:54 PST ---
Created an attachment (id=14884)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=14884)
Fix


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858


Stephane Marchesin <marchesin at icps.u-strasbg.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Stephane Marchesin <marchesin at icps.u-strasbg.fr> 
2008-07-17 16:18:46 PST ---
Applied, thanks. Note that you still need fixes for the drm.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858





--- Comment #3 from Brad Smith <brad at comstyle.com>  2008-07-17 21:28:03
PST ---
The patch is hackish at best. What should be done is copy the bits from the X
server to properly detect the macros to use as was done with the Radeon driver
recently..

http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=commitdiff_plain;h=52459745ec05de88adbc087e9566fe6d97ef424b;hp=67a6ac0001bc9d062aa426384a11a41fa7a1c09a

http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=commitdiff_plain;h=32e1d1daf4f68ea37624afaa2bc1ea7742e1163b;hp=dca522355a9039eca6efaba3b36397b246800f94

This will ensure proper portability and fix Nouveau on OpenBSD, DragonFlyBSD,
Solaris and other OS's at least with regard to the endian swapping macros.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858


Brad Smith <brad at comstyle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #4 from Brad Smith <brad at comstyle.com>  2008-07-21 15:09:39
PST ---
Reopened. Take note of the previous comment.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858





--- Comment #5 from Stephane Marchesin <marchesin at icps.u-strasbg.fr> 
2008-07-22 05:00:46 PST ---
(In reply to comment #4)
> Reopened. Take note of the previous comment.
> 
Sure, please feel free to send patches.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=14858


Francisco Jerez <currojerez at riseup.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Francisco Jerez <currojerez at riseup.net>  2010-03-27
05:45:55 PST ---
The DDX no longer depends on byteswap.h, nv_bios.c doesn't even exist
anymore,
closing...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.