Eric Sandeen
2014-Aug-01 23:12 UTC
[PATCH 00/12] disk-io.c / open_ctree cleanup & refactoring
This is mostly to refactor open_ctree(); at the end of the series it's "only" around 600 lines instead of 900. The first 2 patches are just little cleanups I saw while doing this; the 3rd actually is something of a bugfix. The rest are refactoring - this is a bit of an RFC still; some seem like clear groups of code to move out of the way, others are a bit more gratuitous. Perhaps after these 300 lines are moved out of the way, folks who are familiar with the code can spot other reasonable groupings or functionality which could also be factored out. There are still large swaths of random initializations; I though about "btrfs_initialize_locks_and_stuff()" but decided against it. :) Anyway, it builds & passes default xfstests "-g auto" runs, so it can't be all bad. Let me know what you think. Different function names might be better, better symmetry with close_ctree() might be good, but it's a start. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html