samba - Jun 2014 - samba-tool issue

I mis-typed a value using samba tool and had an error:

 bin/samba-tool domain passwordsettings set --min-pwd-age=-
ERROR(<type 'exceptions.ValueError'>): uncaught exception -
invalid literal
for int() with base 10: '-'
  File
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/__init__.py",
line 175, in _run
    return self.run(*args, **kwargs)
  File
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/domain.py",
line
1151, in run
    min_pwd_age = int(min_pwd_age)

So, yes, I can always retype it. But I was thinking it would be better to
put a check on the parsed value to assure that its an integer.

Is this python code? I may be able to make this change.

-- 
David Bear
mobile: (602) 903-6476

Hello David,

Am 26.06.2014 20:37, schrieb David Bear:
> I mis-typed a value using samba tool and had an error:
> 
>  bin/samba-tool domain passwordsettings set --min-pwd-age=-
> ERROR(<type 'exceptions.ValueError'>): uncaught exception -
invalid literal
> for int() with base 10: '-'
>   File
>
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/__init__.py",
> line 175, in _run
>     return self.run(*args, **kwargs)
>   File
>
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/domain.py",
line
> 1151, in run
>     min_pwd_age = int(min_pwd_age)
> 
> So, yes, I can always retype it. But I was thinking it would be better to
> put a check on the parsed value to assure that its an integer.
> 
> Is this python code? I may be able to make this change.

There are many uncaught exceptions in samba-tool. If would be great, if
you could write a patch. Send it to samba-technical for review.


Regards,
Marc