Anand Jain
2014-Jul-15 08:26 UTC
[PATCH 1/1] btrfs-progs: fix wrong message about forcing the mixed group profile
When the added disk is small, the function btrfs_prepare_device() would
print message indicating that mixed group is forced, apparently thats
not true
reproducer:
mkfs.btrfs -f -draid1 -mraid1 /dev/sdd /dev/sdc
::
SMALL VOLUME: forcing mixed metadata/data groups <---- WRONG
mount /dev/sdd /btrfs
btrfs fi df /btrfs
Data, RAID1: total=126.25MiB, used=128.00KiB
Data, single: total=8.00MiB, used=0.00B
System, RAID1: total=8.00MiB, used=16.00KiB
System, single: total=4.00MiB, used=0.00B
Metadata, RAID1: total=126.25MiB, used=112.00KiB
Metadata, single: total=8.00MiB, used=0.00B
GlobalReserve, single: total=16.00MiB, used=0.00B
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/utils.c b/utils.c
index 673134e..fbc5bde 100644
--- a/utils.c
+++ b/utils.c
@@ -705,10 +705,8 @@ int btrfs_prepare_device(int fd, char *file, int zero_end,
u64 *block_count_ret,
if (max_block_count)
block_count = min(block_count, max_block_count);
- if (block_count < BTRFS_MKFS_SMALL_VOLUME_SIZE && !(*mixed)) {
- printf("SMALL VOLUME: forcing mixed metadata/data groups\n");
+ if (block_count < BTRFS_MKFS_SMALL_VOLUME_SIZE && !(*mixed))
*mixed = 1;
- }
if (discard) {
/*
--
2.0.0.153.g79dcccc
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html