Currently, the tinc application which is part of tinc 1.1 does not support the ability to handle `Name = $HOST` lines in tinc.conf. This set of patches refactors get_name in order to be able to support this configuration option in the tinc binary. After having read through the codebase, it seems like we could really do for a heavy refactoring as there is a lot of poorly coupled and duplicated code. Unfortunately I don't have much time at the moment to look into a better fix for these issues. I'll probably start hacking on the codebase in the coming weeks to fix up the builds. Best, William -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20140824/88653277/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-utils-Refactor-get_name-s-functionality-into-util-fo.patch Type: application/octet-stream Size: 3239 bytes Desc: not available URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20140824/88653277/attachment.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-utils-Refactor-check_id-out-of-protocol-for-global-a.patch Type: application/octet-stream Size: 3043 bytes Desc: not available URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20140824/88653277/attachment-0001.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-tincctl-Use-replace_name-to-properly-replace-and-val.patch Type: application/octet-stream Size: 2035 bytes Desc: not available URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20140824/88653277/attachment-0002.obj>
On Sun, Aug 24, 2014 at 11:38:59PM -0700, William Kennington wrote:> Currently, the tinc application which is part of tinc 1.1 does not support > the ability to handle `Name = $HOST` lines in tinc.conf. This set of > patches refactors get_name in order to be able to support this > configuration option in the tinc binary.Thanks, I've committed them. But maybe it might be better to move check_id() and replace_name() to names.c?> After having read through the codebase, it seems like we could really do > for a heavy refactoring as there is a lot of poorly coupled and duplicated > code. Unfortunately I don't have much time at the moment to look into a > better fix for these issues. I'll probably start hacking on the codebase in > the coming weeks to fix up the builds.Great! It might be good if you send an email to this list what you plan to refactor and how before you start on it. -- Met vriendelijke groet / with kind regards, Guus Sliepen <guus at tinc-vpn.org> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20140825/ac5917bb/attachment.sig>