Hi, I found a small bug there. BTW which way is expected to send patches? Attach a couple of git-format-patch(ed) patches in email, use git-send-email or push to a git repository and notify the list? Cheers, diff --git a/libswfdec/swfdec_mouse_as.c b/libswfdec/swfdec_mouse_as.c index d4d53d9..9483bbf 100644 --- a/libswfdec/swfdec_mouse_as.c +++ b/libswfdec/swfdec_mouse_as.c @@ -31,7 +31,7 @@ swfdec_mouse_addListener (SwfdecAsObject *object, guint argc, SwfdecAsValue *arg { SwfdecPlayer *player = SWFDEC_PLAYER (object->context); - if (!SWFDEC_IS_AS_OBJECT (&argv[0])) + if (!SWFDEC_AS_VALUE_IS_OBJECT (&argv[0])) return; swfdec_listener_add (player->mouse_listener, SWFDEC_AS_VALUE_GET_OBJECT (&argv[0])); } -- Duy
Well actually there are two bugs. One in swfdec_mouse_addListener and another same bug in swfdec_mouse_removeListener On 6/2/07, Nguyen Thai Ngoc Duy <pclouds at gmail.com> wrote:> Hi, > > I found a small bug there. BTW which way is expected to send patches? > Attach a couple of git-format-patch(ed) patches in email, use > git-send-email or push to a git repository and notify the list? > > Cheers, > > diff --git a/libswfdec/swfdec_mouse_as.c b/libswfdec/swfdec_mouse_as.c > index d4d53d9..9483bbf 100644 > --- a/libswfdec/swfdec_mouse_as.c > +++ b/libswfdec/swfdec_mouse_as.c > @@ -31,7 +31,7 @@ swfdec_mouse_addListener (SwfdecAsObject *object, > guint argc, SwfdecAsValue *arg > { > SwfdecPlayer *player = SWFDEC_PLAYER (object->context); > > - if (!SWFDEC_IS_AS_OBJECT (&argv[0])) > + if (!SWFDEC_AS_VALUE_IS_OBJECT (&argv[0])) > return; > swfdec_listener_add (player->mouse_listener, > SWFDEC_AS_VALUE_GET_OBJECT (&argv[0])); > } > -- > Duy >-- Duy
On 6/3/07, Nguyen Thai Ngoc Duy <pclouds at gmail.com> wrote:> Hi, > > I found a small bug there. BTW which way is expected to send patches? > Attach a couple of git-format-patch(ed) patches in email, use > git-send-email or push to a git repository and notify the list? >That depends quite a bit on the patch. If it's something small or obvious like this, I'm fine with anything, from poking me on IRC up to sending a mail or filing a bug. For bigger patches that are still obvious I have no idea. I'm using GMail's web interface for my mail, so I'll have to do manual work in every case. Do what you like best. For patches that are not instant-apply and require discussion I prefer a bug in bugzilla so they won't be forgotten. And depending on the size of the feature and the patch developer's interest, attaching patches in bugzilla or a custom git repository make sense in that case. I'll probably develop a preference when more people start sending me patches, but since you're the 3rd or 4th person to send some, I haven't really thought about the preferred way. ;) Cheers, Benjamin
Possibly Parallel Threads
- Branch 'as' - 5 commits - libswfdec/swfdec_mouse_as.c libswfdec/swfdec_movie_asprops.c test/trace
- 17 commits - doc/swfdec-sections.txt libswfdec/compiler.c libswfdec/.gitignore libswfdec/Makefile.am libswfdec/swfdec_asbroadcaster.c libswfdec/swfdec_as_context.c libswfdec/swfdec_as_object.c libswfdec/swfdec_as_object.h libswfdec/swfdec_as_strings.c
- Branch 'as' - 8 commits - libswfdec/Makefile.am libswfdec/swfdec_as_context.c libswfdec/swfdec_as_frame.c libswfdec/swfdec_as_frame.h libswfdec/swfdec_as_interpret.c libswfdec/swfdec_as_number.c libswfdec/swfdec_as_scope.h
- unable to create array with "blah = Array();"
- as branch progress report