Ocfs2 devel - Jan 2014 - [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

From: Younger Liu <younger.liucn at gmail.com>
Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly

If filesystem is readonly, there is no need to flush drive's caches or
force any uncommitted transactions.

Signed-off-by: Younger Liu <younger.liucn at gmail.com>
Cc: Joel Becker <jlbec at evilplan.org>
Cc: Mark Fasheh <mfasheh at suse.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
---

 fs/ocfs2/file.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN fs/ocfs2/file.c~ocfs2-fix-ocfs2_sync_file-if-filesystem-is-readonly
fs/ocfs2/file.c
--- a/fs/ocfs2/file.c~ocfs2-fix-ocfs2_sync_file-if-filesystem-is-readonly
+++ a/fs/ocfs2/file.c
@@ -185,6 +185,9 @@ static int ocfs2_sync_file(struct file *
 			      file->f_path.dentry->d_name.name,
 			      (unsigned long long)datasync);
 
+	if (ocfs2_is_hard_readonly(osb) || ocfs2_is_soft_readonly(osb))
+		return 0;
+
 	err = filemap_write_and_wait_range(inode->i_mapping, start, end);
 	if (err)
 		return err;
_

On 01/24/2014 02:46 PM, akpm at linux-foundation.org
wrote:
> From: Younger Liu <younger.liucn at gmail.com>
> Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly
>
> If filesystem is readonly, there is no need to flush drive's caches or
> force any uncommitted transactions.
An ocfs2 filesystem can be set to read-only because of an error, in 
which case, you should return -EROFS.

Nak.


-- 
Goldwyn

On Fri, Jan 24, 2014 at 12:46:59PM -0800, akpm at linux-foundation.org
wrote:
> From: Younger Liu <younger.liucn at gmail.com>
> Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly
> 
> If filesystem is readonly, there is no need to flush drive's caches or
> force any uncommitted transactions.
> 
> Signed-off-by: Younger Liu <younger.liucn at gmail.com>
> Cc: Joel Becker <jlbec at evilplan.org>
> Cc: Mark Fasheh <mfasheh at suse.com>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Looks good, thanks for this.

Signed-off-by: Mark Fasheh <mfasheh at suse.de>
	--Mark

--
Mark Fasheh