Konrad Rzeszutek Wilk
2013-Dec-13 02:10 UTC
[PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI
From: Ian Campbell <Ian.Campbell@citrix.com> Allows for more fine grained error reporting. Only used by PVH and ARM both of which are marked EXPERIMENTAL precisely because the ABI is not yet stable Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- arch/x86/xen/mmu.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index 1d1fbdb..a31449f 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -2541,14 +2541,16 @@ static int pvh_add_to_xen_p2m(unsigned long lpfn, unsigned long fgmfn, }; xen_ulong_t idx = fgmfn; xen_pfn_t gpfn = lpfn; + int err = 0; set_xen_guest_handle(xatp.idxs, &idx); set_xen_guest_handle(xatp.gpfns, &gpfn); + set_xen_guest_handle(xatp.errs, &err); rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp); - if (rc) - pr_warn("d0: Failed to map pfn (0x%lx) to mfn (0x%lx) rc:%d\n", - lpfn, fgmfn, rc); + if (rc || err) + pr_warn("d0: Failed to map pfn (0x%lx) to mfn (0x%lx) rc:%d:%d\n", + lpfn, fgmfn, rc, err); return rc; } -- 1.7.7.6
David Vrabel
2013-Dec-13 11:35 UTC
Re: [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI
On 13/12/13 02:10, Konrad Rzeszutek Wilk wrote:> From: Ian Campbell <Ian.Campbell@citrix.com> > > Allows for more fine grained error reporting. Only used by PVH and > ARM both of which are marked EXPERIMENTAL precisely because the ABI > is not yet stableThis should be folded into patch 7. David
Konrad Rzeszutek Wilk
2013-Dec-13 14:27 UTC
Re: [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI
On Fri, Dec 13, 2013 at 11:35:28AM +0000, David Vrabel wrote:> On 13/12/13 02:10, Konrad Rzeszutek Wilk wrote: > > From: Ian Campbell <Ian.Campbell@citrix.com> > > > > Allows for more fine grained error reporting. Only used by PVH and > > ARM both of which are marked EXPERIMENTAL precisely because the ABI > > is not yet stable > > This should be folded into patch 7.In "07/14] xen/x86: remove duplicated include from enlighten.c" ?> > David
David Vrabel
2013-Dec-13 14:30 UTC
Re: [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI
On 13/12/13 14:27, Konrad Rzeszutek Wilk wrote:> On Fri, Dec 13, 2013 at 11:35:28AM +0000, David Vrabel wrote: >> On 13/12/13 02:10, Konrad Rzeszutek Wilk wrote: >>> From: Ian Campbell <Ian.Campbell@citrix.com> >>> >>> Allows for more fine grained error reporting. Only used by PVH and >>> ARM both of which are marked EXPERIMENTAL precisely because the ABI >>> is not yet stable >> >> This should be folded into patch 7. > > In "07/14] xen/x86: remove duplicated include from enlighten.c" ?Sorry. I meant: [06/14] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings I stopped calling out places where patches should be folded/refactored at this point. David