rsync - Nov 2013 - [Bug 10272] New: resource fork handling is broken in 3.1.0

https://bugzilla.samba.org/show_bug.cgi?id=10272

           Summary: resource fork handling is broken in 3.1.0
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: bugzilla-samba at narthex.bantha.org
         QAContact: rsync-qa at samba.org


In rsync 3.1.0, when rsyncing between two Macs running OS X (I've tried with
both Mountain Lion and Snow Leopard), rsync -vaX chokes on files with resource
forks, with the following error message:

$ rsync -vaX test2-20131116 remotehost:/tmp/
sending incremental file list
need to write 836037 bytes, iobuf.out.buf is only 65532 bytes.
rsync error: protocol incompatibility (code 2) at io.c(599) [sender=3.1.0]

Note that the directory "test2-20131116" contained a single file with
a
836037-byte resource fork.  (Perhaps the problem arises only with resource
forks larger than some default buffer size?)

Both sides of this attempted transfer were running rsync 3.1.0.  When, instead,
both sides were running rsync 3.0.9, there was no error message and the
resource fork transferred (apparently) correctly.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10272

--- Comment #1 from Mike Bombich <mike at bombich.com> 2013-11-17 18:11:50
UTC ---
resource fork data needs to be chunked in sys_lgetxattr(). The changes to
accommodate this are already in the hfs-compression patch, though it's
probably
a good idea to get the lib/sysxattr.c changes that are more generally
applicable to OS X moved into the main branch.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10272

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Wayne Davison <wayned at samba.org> 2013-11-25
21:13:40 UTC ---
This error looks like the read happened fine, but it tried to write the huge
resource fork in one buffer call that didn't support flushing the buffer
between chunks.  I'm checking in a change that will fix this.  I'm also
moving
the chunked xattr reading from the hfs-compression patch into the main OS X
code.  Committed to git.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.