rsync - Oct 2013 - [Bug 10238] New: --dry-run does not change directory, causes --link-dest failure on symlinks

https://bugzilla.samba.org/show_bug.cgi?id=10238

           Summary: --dry-run does not change directory, causes
                    --link-dest failure on symlinks
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: lekensteyn at gmail.com
         QAContact: rsync-qa at samba.org


Created attachment 9350
  --> https://bugzilla.samba.org/attachment.cgi?id=9350
testcase

When running rsync --xattrs --link-dest with --dry-run, a warning is printed if
the current directory does not match the source directory. Inspection with
strace showed that the current directory is not changed when using --dry-run.

An example message:

    rsync: get_xattr_names:
llistxattr(""/tmp/test-rsync-bug/2/a/file"",1024)
failed: No such file or directory (2)


See attached shell script.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10238

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Wayne Davison <wayned at samba.org> 2013-11-25
17:19:55 UTC ---
Both symlinks and devices had a bug where the finding of a link-dest item to
use caused the itemize info to break when --dry-run was in effect.  I changed
the code to itemize against the found alt-dest file (as normal files already
did), and that fixes this up (fix is in git).  Thanks for the handy test
script!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.