Dario Faggioli
2013-Sep-13 09:13 UTC
Backport request: 5d98adc3e5e85 (tools/gdbsx: fix build failure with glibc-2.17) to 4.2.x
Hi,
Here on my box (Debian with libc version 2.17-92+b1) building the tools
for 4.2.3 is broken as follows:
gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .xg_main.o.d
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -Werror
-Wmissing-prototypes
-I/home/dario/Sources/xen/xen/xen-4.2.3/tools/debugger/gdbsx/xg/../../../../tools/include
-c -o xg_main.o xg_main.c
xg_main.c: In function ‘_domctl_hcall’:
xg_main.c:181:52: error: ‘ulong’ undeclared (first use in this function)
rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall);
^
xg_main.c:181:52: note: each undeclared identifier is reported only once for
each function it appears in
xg_main.c: In function ‘_check_hyp’:
xg_main.c:221:52: error: ‘ulong’ undeclared (first use in this function)
rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall);
^
make[4]: *** [xg_main.o] Error 1
make[4]: Leaving directory
`/home/dario/Sources/xen/xen/xen-4.2.3/tools/debugger/gdbsx/xg''
make[3]: *** [all] Error 2
make[3]: Leaving directory
`/home/dario/Sources/xen/xen/xen-4.2.3/tools/debugger/gdbsx''
make[2]: *** [subdir-install-debugger/gdbsx] Error 2
make[2]: Leaving directory
`/home/dario/Sources/xen/xen/xen-4.2.3/tools''
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory
`/home/dario/Sources/xen/xen/xen-4.2.3/tools''
make: *** [install-tools] Error 2
Just cherry picking 5d98adc3e5e859ba23f62ca63450f6a60a9c5e2f fixed the
issue, which makes perfect sense, as that change does "tools/gdbsx: fix
build failure with glibc-2.17".
I therefore think it should be backported... Should I send a proper
patch against RELEASE-4.2.3 myself? Of course I can, just asking because
cherry-pick seems to work already, so I''m not sure what would be
better.
Just let me know.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Ian Jackson
2013-Sep-13 10:02 UTC
Re: Backport request: 5d98adc3e5e85 (tools/gdbsx: fix build failure with glibc-2.17) to 4.2.x
Dario Faggioli writes ("Backport request: 5d98adc3e5e85 (tools/gdbsx: fix
build failure with glibc-2.17) to 4.2.x"):> Here on my box (Debian with libc version 2.17-92+b1) building the tools
> for 4.2.3 is broken as follows:
>
> gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD
-MF .xg_main.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-fno-optimize-sibling-calls -Werror -Wmissing-prototypes
-I/home/dario/Sources/xen/xen/xen-4.2.3/tools/debugger/gdbsx/xg/../../../../tools/include
-c -o xg_main.o xg_main.c
> xg_main.c: In function ‘_domctl_hcall’:
> xg_main.c:181:52: error: ‘ulong’ undeclared (first use in this function)
> rc = ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall);
...> Just cherry picking 5d98adc3e5e859ba23f62ca63450f6a60a9c5e2f fixed the
> issue, which makes perfect sense, as that change does "tools/gdbsx:
fix
> build failure with glibc-2.17".
I have backported this to staging-4.2. (Using git-cherry-pick.)
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel