Andrew Cooper
2013-Sep-12 17:45 UTC
[PATCH] sched/credit: Remove redundant assignments from alloc_* functions
Noticed because Coverity was complaining at the atomic_set(), but because of
the use of xzalloc(), these assignments of 0 are completely redundent.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: George Dunlap <george.dunlap@eu.citrix.com>
---
xen/common/sched_credit.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index 0b81662..dbe6de6 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -858,8 +858,6 @@ csched_alloc_vdata(const struct scheduler *ops, struct vcpu
*vc, void *dd)
INIT_LIST_HEAD(&svc->active_vcpu_elem);
svc->sdom = dd;
svc->vcpu = vc;
- atomic_set(&svc->credit, 0);
- svc->flags = 0U;
svc->pri = is_idle_domain(vc->domain) ?
CSCHED_PRI_IDLE : CSCHED_PRI_TS_UNDER;
SCHED_VCPU_STATS_RESET(svc);
@@ -1081,11 +1079,9 @@ csched_alloc_domdata(const struct scheduler *ops, struct
domain *dom)
/* Initialize credit and weight */
INIT_LIST_HEAD(&sdom->active_vcpu);
- sdom->active_vcpu_count = 0;
INIT_LIST_HEAD(&sdom->active_sdom_elem);
sdom->dom = dom;
sdom->weight = CSCHED_DEFAULT_WEIGHT;
- sdom->cap = 0U;
return (void *)sdom;
}
--
1.7.10.4
George Dunlap
2013-Sep-13 09:44 UTC
Re: [PATCH] sched/credit: Remove redundant assignments from alloc_* functions
On Thu, Sep 12, 2013 at 6:45 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:> Noticed because Coverity was complaining at the atomic_set(), but because of > the use of xzalloc(), these assignments of 0 are completely redundent. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>Acked-by: George Dunlap <george.dunlap@eu.citrix.com>> CC: Keir Fraser <keir@xen.org> > CC: Jan Beulich <JBeulich@suse.com> > CC: George Dunlap <george.dunlap@eu.citrix.com> > --- > xen/common/sched_credit.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c > index 0b81662..dbe6de6 100644 > --- a/xen/common/sched_credit.c > +++ b/xen/common/sched_credit.c > @@ -858,8 +858,6 @@ csched_alloc_vdata(const struct scheduler *ops, struct vcpu *vc, void *dd) > INIT_LIST_HEAD(&svc->active_vcpu_elem); > svc->sdom = dd; > svc->vcpu = vc; > - atomic_set(&svc->credit, 0); > - svc->flags = 0U; > svc->pri = is_idle_domain(vc->domain) ? > CSCHED_PRI_IDLE : CSCHED_PRI_TS_UNDER; > SCHED_VCPU_STATS_RESET(svc); > @@ -1081,11 +1079,9 @@ csched_alloc_domdata(const struct scheduler *ops, struct domain *dom) > > /* Initialize credit and weight */ > INIT_LIST_HEAD(&sdom->active_vcpu); > - sdom->active_vcpu_count = 0; > INIT_LIST_HEAD(&sdom->active_sdom_elem); > sdom->dom = dom; > sdom->weight = CSCHED_DEFAULT_WEIGHT; > - sdom->cap = 0U; > > return (void *)sdom; > } > -- > 1.7.10.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel