Stefano Stabellini
2013-Jun-27 13:28 UTC
[PATCH] xen: ifdef CONFIG_HIBERNATE_CALLBACKS xen_*_suspend
xen_hvm_post_suspend, xen_pre_suspend, xen_post_suspend are only used if
CONFIG_HIBERNATE_CALLBACKS is defined, resulting in:
drivers/xen/manage.c:46:13: warning: ‘xen_hvm_post_suspend’ defined but not used
[-Wunused-function]
drivers/xen/manage.c:52:13: warning: ‘xen_pre_suspend’ defined but not used
[-Wunused-function]
drivers/xen/manage.c:59:13: warning: ‘xen_post_suspend’ defined but not used
[-Wunused-function]
If the kernel config is missing CONFIG_HIBERNATE_CALLBACKS.
Simply ifdef CONFIG_HIBERNATE_CALLBACKS the three functions.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
drivers/xen/manage.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 412b96c..b1005d4 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -43,6 +43,7 @@ struct suspend_info {
void (*post)(int cancelled);
};
+#ifdef CONFIG_HIBERNATE_CALLBACKS
static void xen_hvm_post_suspend(int cancelled)
{
xen_arch_hvm_post_suspend(cancelled);
@@ -63,7 +64,6 @@ static void xen_post_suspend(int cancelled)
xen_mm_unpin_all();
}
-#ifdef CONFIG_HIBERNATE_CALLBACKS
static int xen_suspend(void *data)
{
struct suspend_info *si = data;
--
1.7.2.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
konrad wilk
2013-Jun-27 20:10 UTC
Re: [PATCH] xen: ifdef CONFIG_HIBERNATE_CALLBACKS xen_*_suspend
On 6/27/2013 9:28 AM, Stefano Stabellini wrote:> xen_hvm_post_suspend, xen_pre_suspend, xen_post_suspend are only used if > CONFIG_HIBERNATE_CALLBACKS is defined, resulting in: > > drivers/xen/manage.c:46:13: warning: ‘xen_hvm_post_suspend’ defined but not used [-Wunused-function] > drivers/xen/manage.c:52:13: warning: ‘xen_pre_suspend’ defined but not used [-Wunused-function] > drivers/xen/manage.c:59:13: warning: ‘xen_post_suspend’ defined but not used [-Wunused-function] > > If the kernel config is missing CONFIG_HIBERNATE_CALLBACKS. > > Simply ifdef CONFIG_HIBERNATE_CALLBACKS the three functions. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > drivers/xen/manage.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c > index 412b96c..b1005d4 100644 > --- a/drivers/xen/manage.c > +++ b/drivers/xen/manage.c > @@ -43,6 +43,7 @@ struct suspend_info { > void (*post)(int cancelled); > }; > > +#ifdef CONFIG_HIBERNATE_CALLBACKS > static void xen_hvm_post_suspend(int cancelled) > { > xen_arch_hvm_post_suspend(cancelled); > @@ -63,7 +64,6 @@ static void xen_post_suspend(int cancelled) > xen_mm_unpin_all(); > } > > -#ifdef CONFIG_HIBERNATE_CALLBACKS > static int xen_suspend(void *data) > { > struct suspend_info *si = data;Looks ok. Will queue it up for 3.11 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel