Hector Bustillos
2013-Jun-27 04:33 UTC
A change that may not hurt anybody - move the js include tag to the bottom
I was working a lot on performance improvements on rails apps when I realize that we always talking about ways to improve the page load of our apps, basically ways to show things faster. One of those ''ways'' is to simple move the js include to the bottom of our page. So, I got this questions why not give this super simple improvement to rails just by moving the js include on the application layout to the bottom?. this is my pull request https://github.com/rails/rails/pull/11132 maybe it''s silly but I think it doesn''t hurt anybody. Hector. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
Mohamed Wael Khobalatte
2013-Jun-27 16:36 UTC
Re: A change that may not hurt anybody - move the js include tag to the bottom
This is such an obvious tip that I am sure this has been discussed before. On Thu, Jun 27, 2013 at 5:33 AM, Hector Bustillos < hector.bustillos@crowdint.com> wrote:> I was working a lot on performance improvements on rails apps when I > realize that we always talking about ways to improve the page load of our > apps, basically ways to show things faster. One of those ''ways'' is to > simple move the js include to the bottom of our page. > So, I got this questions why not give this super simple improvement to > rails just by moving the js include on the application layout to the > bottom?. > > this is my pull request https://github.com/rails/rails/pull/11132 maybe > it''s silly but I think it doesn''t hurt anybody. > > Hector. > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- Mohamed Wael Khobalatte -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
Hector Bustillos
2013-Jun-28 14:38 UTC
Re: A change that may not hurt anybody - move the js include tag to the bottom
Yes, you can follow the thread here https://github.com/rails/rails/pull/5815 nevertheless I''m still think is a good idea and should be promoted On Thursday, June 27, 2013 11:36:29 AM UTC-5, Mohamed Wael Khobalatte wrote:> > This is such an obvious tip that I am sure this has been discussed before. > > > On Thu, Jun 27, 2013 at 5:33 AM, Hector Bustillos < > hector.b...@crowdint.com <javascript:>> wrote: > >> I was working a lot on performance improvements on rails apps when I >> realize that we always talking about ways to improve the page load of our >> apps, basically ways to show things faster. One of those ''ways'' is to >> simple move the js include to the bottom of our page. >> So, I got this questions why not give this super simple improvement to >> rails just by moving the js include on the application layout to the >> bottom?. >> >> this is my pull request https://github.com/rails/rails/pull/11132 maybe >> it''s silly but I think it doesn''t hurt anybody. >> >> Hector. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-co...@googlegroups.com <javascript:>. >> To post to this group, send email to rubyonra...@googlegroups.com<javascript:> >> . >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > > > -- > Mohamed Wael Khobalatte > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.