Stefano Stabellini
2013-Jun-13 17:33 UTC
Re: [Qemu-devel] [PATCH] Remove hardcoded xen-platform device initialization
On Thu, 13 Jun 2013, Paul Durrant wrote:> The xen-platform device should be initialized by the Xen toolstack by > passing the appropriate -device argument on the command line. > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>This patch is problematic because we can''t know for sure the version of upstream QEMU that is going to be used with Xen. If we apply this patch and QEMU 1.5 is going to be used with Xen 4.2, guests won''t be able to use PV drivers.> hw/i386/pc_piix.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index d618570..e25012d 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -174,9 +174,6 @@ static void pc_init1(MemoryRegion *system_memory, > pc_register_ferr_irq(gsi[13]); > > pc_vga_init(isa_bus, pci_enabled ? pci_bus : NULL); > - if (xen_enabled()) { > - pci_create_simple(pci_bus, -1, "xen-platform"); > - } > > /* init basic PC hardware */ > pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled());