Anthony PERARD
2013-May-29 18:11 UTC
[PATCH] libxl: Fix qemu-xen command line for vcpus numbers.
On the qemu-xen command line, the number of vcpus initially online and
the number of maximum available vcpus are inverted.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libxl/libxl_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index d10a58f..1e3a9f4 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -533,8 +533,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc
*gc,
nr_set_cpus =
libxl_bitmap_count_set(&b_info->avail_vcpus);
flexarray_append(dm_args, libxl__sprintf(gc,
"%d,maxcpus=%d",
- b_info->max_vcpus,
- nr_set_cpus));
+ nr_set_cpus,
+
b_info->max_vcpus));
} else
flexarray_append(dm_args, libxl__sprintf(gc, "%d",
b_info->max_vcpus));
--
Anthony PERARD
Ian Campbell
2013-May-30 08:58 UTC
Re: [PATCH] libxl: Fix qemu-xen command line for vcpus numbers.
On Wed, 2013-05-29 at 19:11 +0100, Anthony PERARD wrote:> On the qemu-xen command line, the number of vcpus initially online and > the number of maximum available vcpus are inverted. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>Doh! Acked + applied, thanks.> --- > tools/libxl/libxl_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index d10a58f..1e3a9f4 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -533,8 +533,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > nr_set_cpus = libxl_bitmap_count_set(&b_info->avail_vcpus); > > flexarray_append(dm_args, libxl__sprintf(gc, "%d,maxcpus=%d", > - b_info->max_vcpus, > - nr_set_cpus)); > + nr_set_cpus, > + b_info->max_vcpus)); > } else > flexarray_append(dm_args, libxl__sprintf(gc, "%d", > b_info->max_vcpus));