I've got a question. When do i have to use this for aFunctionName() and when do i have to use this for a_function_name() ? Cedric
Le mercredi 7 f?vrier 2007 17:44, Bellegarde Cedric a ?crit?:> When do i have to use this for aFunctionName() and when do i have to use > this for a_function_name() ?After looking at others plugins, NEVER! :) So, here is complete version of my placement patch, it include: - Some code cleanup, place plugin was using this_function_naming_method. I assume it's wrong as i can't see another exemple in compiz code. David, if i am wrong, i have a version of this patch without this code cleanup ;) - Six placement method: Cascade, Centered, Random, LeftCorner, Maximize and Smart! Centered, Random, LeftCorner and Maximize are really simple. For smart placement, i adapt kwin code as requested by David. I think it works, tell me if you have problems with it! Cedric. -------------- next part -------------- A non-text attachment was scrubbed... Name: place.patch Type: text/x-diff Size: 19652 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20070207/4906f8a3/place-0001.bin
Le mercredi 7 f?vrier 2007, Bellegarde Cedric a ?crit?:> I think it works, tell me if you have problems with it!One day i will be able to send a good patch the first time ;) So, after looking at place.c, it seems that also variables use this_notation. So, here the patch without code cleanup, i will wait David behaviour about this. I also fix a bug in placeRandom() And now, i put the patch on my server, it will me prevent me to send you a message everytime i find something to fix ;) http://puffy.homelinux.org/~gnumdk/compiz/patch/place.patch Cedric
On Wed, 2007-02-07 at 17:44 +0100, Bellegarde Cedric wrote:> I've got a question. > > When do i have to use this for aFunctionName() and when do i have to use this > for a_function_name() ?Function names in core uses camel caps (aFunctionName) to match Xlib and OpenGL APIs. Most of my plugins also use camel caps and I suggest that you use it in any plugins you write too but that's of course completely up to you. Place plugin is probably not using camel caps as I got most of that code from metacity. Camel are not used in gwd to better match cairo and gtk. - David