Ryan B. Lynch wrote:> While trying to build RPMs for 4.1.8, I noticed that the
''install.sh''
> script in the ''shorewall-common'' package doesn''t
correctly handle an
> installation directory prefix. Based on the diff since 4.0.10.1, and
> the fact that the indentation around that section is inconsistent, it
> seems like it could be a typo.
>
> In previous versions, the ''install -d ...'' command that
creates the
> ''sbin'' directory in the installation directory should
create the parent,
> as well. In version 4.1.8, the ''install -d ...'' command
(line 204) is
> moved inside an ''if'' statement, so that it
doesn''t run and won''t create
> the ''sbin'' directory and its parent unless run as a
non-root user.
>
> Is this a bug, or a feature intended to discourage building RPMs as root?
>
> In case my description isn''t clear, I attached a patch that fixes
the
> issue--or at least lets me build the RPM as root.
Thanks, Ryan
I''ve applied your patch then tweaked it a bit (we need not create /sbin
or
the destination directory if we''re installing on Cygwin). Incremental
(to
your) patch attached.
-Tom
--
Tom Eastep \ Nothing is foolproof to a sufficiently talented fool
Shoreline, \ http://shorewall.net
Washington USA \ teastep@shorewall.net
PGP Public Key \ https://lists.shorewall.net/teastep.pgp.key
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/