Current xen-unstable, 27010:e5562e4b7558, fails to build in openSuSE 12.1 and later: [ 216s] make[4]: Entering directory `/home/abuild/rpmbuild/BUILD/xen-4.3.27010/dbg/xen/arch/x86/efi'' ... [ 216s] boot.c: In function ''efi_init_memory'': [ 216s] boot.c:1574:13: error: implicit declaration of function ''map_pages_to_xen'' [-Werror=implicit-function-declaration] [ 216s] boot.c:1574:13: error: nested extern declaration of ''map_pages_to_xen'' [-Werror=nested-externs] ... I think 26964:fcd0f296f907 did built ok, but I''m not sure. Olaf
>>> On 09.05.13 at 19:17, Olaf Hering <olaf@aepfle.de> wrote: > Current xen-unstable, 27010:e5562e4b7558, fails to build in openSuSE > 12.1 and later: > > > [ 216s] make[4]: Entering directory > `/home/abuild/rpmbuild/BUILD/xen-4.3.27010/dbg/xen/arch/x86/efi'' > ... > [ 216s] boot.c: In function ''efi_init_memory'': > [ 216s] boot.c:1574:13: error: implicit declaration of function > ''map_pages_to_xen'' [-Werror=implicit-function-declaration] > [ 216s] boot.c:1574:13: error: nested extern declaration of > ''map_pages_to_xen'' [-Werror=nested-externs] > ... > > > I think 26964:fcd0f296f907 did built ok, but I''m not sure.26981:e0340254f8ac moved the declaration around - Stefano, was this change properly build checked on x86 (i.e. also in a build environment new enough to allow the EFI stuff to be built)? Ian, along the same lines - does the test infrastructure not at least build test the EFI code? Jan
On Fri, 10 May 2013, Jan Beulich wrote:> >>> On 09.05.13 at 19:17, Olaf Hering <olaf@aepfle.de> wrote: > > Current xen-unstable, 27010:e5562e4b7558, fails to build in openSuSE > > 12.1 and later: > > > > > > [ 216s] make[4]: Entering directory > > `/home/abuild/rpmbuild/BUILD/xen-4.3.27010/dbg/xen/arch/x86/efi'' > > ... > > [ 216s] boot.c: In function ''efi_init_memory'': > > [ 216s] boot.c:1574:13: error: implicit declaration of function > > ''map_pages_to_xen'' [-Werror=implicit-function-declaration] > > [ 216s] boot.c:1574:13: error: nested extern declaration of > > ''map_pages_to_xen'' [-Werror=nested-externs] > > ... > > > > > > I think 26964:fcd0f296f907 did built ok, but I''m not sure. > > 26981:e0340254f8ac moved the declaration around - Stefano, > was this change properly build checked on x86 (i.e. also in a build > environment new enough to allow the EFI stuff to be built)?I ran "make xen" on x86 to build test it. Is the EFI target different not included in "make xen"?> Ian, along the same lines - does the test infrastructure not at > least build test the EFI code?
>>> On 10.05.13 at 13:04, Stefano Stabellini <stefano.stabellini@eu.citrix.com>wrote:> On Fri, 10 May 2013, Jan Beulich wrote: >> >>> On 09.05.13 at 19:17, Olaf Hering <olaf@aepfle.de> wrote: >> > Current xen-unstable, 27010:e5562e4b7558, fails to build in openSuSE >> > 12.1 and later: >> > >> > >> > [ 216s] make[4]: Entering directory >> > `/home/abuild/rpmbuild/BUILD/xen-4.3.27010/dbg/xen/arch/x86/efi'' >> > ... >> > [ 216s] boot.c: In function ''efi_init_memory'': >> > [ 216s] boot.c:1574:13: error: implicit declaration of function >> > ''map_pages_to_xen'' [-Werror=implicit-function-declaration] >> > [ 216s] boot.c:1574:13: error: nested extern declaration of >> > ''map_pages_to_xen'' [-Werror=nested-externs] >> > ... >> > >> > >> > I think 26964:fcd0f296f907 did built ok, but I''m not sure. >> >> 26981:e0340254f8ac moved the declaration around - Stefano, >> was this change properly build checked on x86 (i.e. also in a build >> environment new enough to allow the EFI stuff to be built)? > > I ran "make xen" on x86 to build test it. > Is the EFI target different not included in "make xen"?It is being included there as long as your tool chain meets the requirements. If it doesn''t, a message gets printed towards the end of the hypervisor build. Jan
On Fri, 2013-05-10 at 12:17 +0100, Jan Beulich wrote:> >>> On 10.05.13 at 13:04, Stefano Stabellini <stefano.stabellini@eu.citrix.com> > wrote: > > On Fri, 10 May 2013, Jan Beulich wrote: > >> >>> On 09.05.13 at 19:17, Olaf Hering <olaf@aepfle.de> wrote: > >> > Current xen-unstable, 27010:e5562e4b7558, fails to build in openSuSE > >> > 12.1 and later: > >> > > >> > > >> > [ 216s] make[4]: Entering directory > >> > `/home/abuild/rpmbuild/BUILD/xen-4.3.27010/dbg/xen/arch/x86/efi'' > >> > ... > >> > [ 216s] boot.c: In function ''efi_init_memory'': > >> > [ 216s] boot.c:1574:13: error: implicit declaration of function > >> > ''map_pages_to_xen'' [-Werror=implicit-function-declaration] > >> > [ 216s] boot.c:1574:13: error: nested extern declaration of > >> > ''map_pages_to_xen'' [-Werror=nested-externs] > >> > ... > >> > > >> > > >> > I think 26964:fcd0f296f907 did built ok, but I''m not sure. > >> > >> 26981:e0340254f8ac moved the declaration around - Stefano, > >> was this change properly build checked on x86 (i.e. also in a build > >> environment new enough to allow the EFI stuff to be built)? > > > > I ran "make xen" on x86 to build test it. > > Is the EFI target different not included in "make xen"? > > It is being included there as long as your tool chain meets the > requirements. If it doesn''t, a message gets printed towards > the end of the hypervisor build.Looks like my build environment (Debian Squeeze) doesn''t meet the requirements. Which since the test system also uses Squeeze likely implies it doesn''t either. With Debian Wheezy having just been released I suppose this might naturally take care of itself once the relevant upgrades happen. Ian.