Wang Sheng-Hui
2013-Mar-21 06:13 UTC
[PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
_require_nobigloopfs has been removed. We should use _require_no_large_scratch_dev in the test script. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/276 b/276 index 40b30cf..87363ca 100755 --- a/276 +++ b/276 @@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev _require_btrfs inspect-internal _require_command "/usr/sbin/filefrag" -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wang Sheng-Hui
2013-Mar-25 04:35 UTC
Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
On 2013年03月21日 14:13, Wang Sheng-Hui wrote:> _require_nobigloopfs has been removed. > We should use _require_no_large_scratch_dev in the test script. > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > 276 | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/276 b/276 > index 40b30cf..87363ca 100755 > --- a/276 > +++ b/276 > @@ -58,8 +58,7 @@ _need_to_be_root > _supported_fs btrfs > _supported_os Linux > _require_scratch > - > -_require_nobigloopfs > +_require_no_large_scratch_dev > _require_btrfs inspect-internal > _require_command "/usr/sbin/filefrag" >Does anyone notice this? I use the upstream xfstests and failed this case for the already-removed function. I think someone patched in but mixed the old function. I've send out this patch for days, but seems no one cares about it. If I'm wrong, please let me know. Thanks, _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
Rich Johnston
2013-Mar-25 13:43 UTC
Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
On 03/21/2013 01:13 AM, Wang Sheng-Hui wrote:> _require_nobigloopfs has been removed. > We should use _require_no_large_scratch_dev in the test script. > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > 276 | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/276 b/276 > index 40b30cf..87363ca 100755 > --- a/276 > +++ b/276 > @@ -58,8 +58,7 @@ _need_to_be_root > _supported_fs btrfs > _supported_os Linux > _require_scratch > - > -_require_nobigloopfs > +_require_no_large_scratch_dev > _require_btrfs inspect-internal > _require_command "/usr/sbin/filefrag" >Thanks for the patch. Not sure what is wrong with your patch (trailing space maybe), but it could not be imported using git quiltimport. The patch itself makes sense so I have committed the attached: Reviewed-by: Rich Johnston <rjohnston@sgi.com> commit 07c1f8d7bae36f2c28ffee6f09c318b1142b6f90 Author: Wang Sheng-Hui <shhuiw@gmail.com> Date: Thu Mar 21 06:13:23 2013 +0000 xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs