Btrfs devel - Jan 2013 - [PATCH] Btrfs-prog/send: fix wrong best-parent assignment in, find_good_parent()

We use find_good_parent() to look for a suit snapshot in the clone source
snapshots as the parent, not the source subvolume of the snapshot which
is about to be sent. fix it

Signed-off-by: Cheng Yang <chenyang.fnst@cn.fujitsu.com>
---
 cmds-send.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cmds-send.c b/cmds-send.c
index 9b47e70..3a88c54 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -150,7 +150,7 @@ static int find_good_parent(struct btrfs_send *s, u64
root_id, u64 *found)
 		if (tmp < 0)
 			tmp *= -1;
 		if (tmp < best_diff) {
-			best_parent = parent;
+			best_parent = parent2;
 			best_diff = tmp;
 		}
 	}
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Thu, January 24, 2013 at 12:53 (+0100), Chen Yang
wrote:
> We use find_good_parent() to look for a suit snapshot in the clone source
> snapshots as the parent, not the source subvolume of the snapshot which
> is about to be sent. fix it
> 
> Signed-off-by: Cheng Yang <chenyang.fnst@cn.fujitsu.com>
> ---
>  cmds-send.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/cmds-send.c b/cmds-send.c
> index 9b47e70..3a88c54 100644
> --- a/cmds-send.c
> +++ b/cmds-send.c
> @@ -150,7 +150,7 @@ static int find_good_parent(struct btrfs_send *s, u64
root_id, u64 *found)
>  		if (tmp < 0)
>  			tmp *= -1;
>  		if (tmp < best_diff) {
> -			best_parent = parent;
> +			best_parent = parent2;
>  			best_diff = tmp;
>  		}
>  	}
> 
Reviewed-by: Jan Schmidt <list.btrfs@jan-o-sch.net>

Thanks,
-Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html