Wei Yongjun
2012-Sep-14 02:29 UTC
[PATCH] Btrfs: using for_each_set_bit_from to simplify the code
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using for_each_set_bit_from() to simplify the code. spatch with a semantic match is used to found this. (coccinelle.lip6.fr) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> --- fs/btrfs/free-space-cache.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 6b10acf..b107e68 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -1454,9 +1454,7 @@ static int search_bitmap(struct btrfs_free_space_ctl *ctl, max_t(u64, *offset, bitmap_info->offset)); bits = bytes_to_bits(*bytes, ctl->unit); - for (i = find_next_bit(bitmap_info->bitmap, BITS_PER_BITMAP, i); - i < BITS_PER_BITMAP; - i = find_next_bit(bitmap_info->bitmap, BITS_PER_BITMAP, i + 1)) { + for_each_set_bit_from(i, bitmap_info->bitmap, BITS_PER_BITMAP) { next_zero = find_next_zero_bit(bitmap_info->bitmap, BITS_PER_BITMAP, i); if ((next_zero - i) >= bits) { @@ -2307,9 +2305,7 @@ static int btrfs_bitmap_cluster(struct btrfs_block_group_cache *block_group, again: found_bits = 0; - for (i = find_next_bit(entry->bitmap, BITS_PER_BITMAP, i); - i < BITS_PER_BITMAP; - i = find_next_bit(entry->bitmap, BITS_PER_BITMAP, i + 1)) { + for_each_set_bit_from(i, entry->bitmap, BITS_PER_BITMAP) { next_zero = find_next_zero_bit(entry->bitmap, BITS_PER_BITMAP, i); if (next_zero - i >= min_bits) { -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at vger.kernel.org/majordomo-info.html
David Sterba
2012-Sep-14 13:31 UTC
Re: [PATCH] Btrfs: using for_each_set_bit_from to simplify the code
On Fri, Sep 14, 2012 at 10:29:02AM +0800, Wei Yongjun wrote:> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Using for_each_set_bit_from() to simplify the code. > > spatch with a semantic match is used to found this. > (coccinelle.lip6.fr) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>Reviewed-by: David Sterba <dsterba@suse.cz> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at vger.kernel.org/majordomo-info.html