When I ran xfstests, 251 got failed cause "cp -axT" did not work as
wish:
cp: cannot overwrite directory `/mnt/scratch/1'' with non-directory
With this patch, 251 has passed.
Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
---
251 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/251 b/251
index fa3d74a..b54e4c3 100755
--- a/251
+++ b/251
@@ -130,7 +130,7 @@ function run_process() {
# Copy content -> partition.
mkdir $SCRATCH_MNT/$p
- cp -axT $content $SCRATCH_MNT/$p
+ cp -axT $content/ $SCRATCH_MNT/$p/
export chpid=$! && wait $chpid &> /dev/null
check_sums
--
1.6.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 10, 2012 at 07:39:20PM +0800, Liu Bo wrote:> When I ran xfstests, 251 got failed cause "cp -axT" did not work as wish: > cp: cannot overwrite directory `/mnt/scratch/1'' with non-directory > > With this patch, 251 has passed.Why would cp give that message with a missing /? I''m not against putting this in, but I''d like to understand what''s going on. Lukas, any idea? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 11 Jan 2012, Christoph Hellwig wrote:> On Tue, Jan 10, 2012 at 07:39:20PM +0800, Liu Bo wrote: > > When I ran xfstests, 251 got failed cause "cp -axT" did not work as wish: > > cp: cannot overwrite directory `/mnt/scratch/1'' with non-directory > > > > With this patch, 251 has passed. > > Why would cp give that message with a missing /? > > I''m not against putting this in, but I''d like to understand what''s going > on. > > Lukas, any idea? >Hi Christoph, the only reason I can think of is probably that Liu is accessing the xfstests directory via symbolic link, hence the ''$content'' addresses the symbolic link and cp is trying to overwrite the directory with non-directory (symlink). The fix is fine for both cases (xfstests as symlink and directory), confirmed with a simple test. Thanks! -Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/11/2012 08:14 PM, Lukas Czerner wrote:> On Wed, 11 Jan 2012, Christoph Hellwig wrote: > >> On Tue, Jan 10, 2012 at 07:39:20PM +0800, Liu Bo wrote: >>> When I ran xfstests, 251 got failed cause "cp -axT" did not work as wish: >>> cp: cannot overwrite directory `/mnt/scratch/1'' with non-directory >>> >>> With this patch, 251 has passed. >> Why would cp give that message with a missing /? >> >> I''m not against putting this in, but I''d like to understand what''s going >> on. >> >> Lukas, any idea? >> > > Hi Christoph, > > the only reason I can think of is probably that Liu is accessing the > xfstests directory via symbolic link, hence the ''$content'' addresses the > symbolic link and cp is trying to overwrite the directory with > non-directory (symlink). > > The fix is fine for both cases (xfstests as symlink and directory), confirmed > with a simple test. >Sorry for not showing the full story in changelog, but symbolic link is the point: [root@kvm tmp]# ll XFStests lrwxrwxrwx 1 root root 32 Jan 1 09:48 XFStests -> /home/kvm_img/liub/xfstests-dev/ thanks, liubo> Thanks! > -Lukas > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html